Improved code (Early return while building audio source)

mlightvn · Jan 28, 2024 · 36fc9bf · 36fc9bf
1 parent ff0eeb0
commit 36fc9bf
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/lib/services/audio_service.dart b/lib/services/audio_service.dart
@@ -259,13 +259,13 @@ class MusifyAudioHandler extends BaseAudioHandler {
     final tag = mapToMediaItem(song, songUrl);
     final audioSource = AudioSource.uri(uri, tag: tag);
 
-    if (!isOffline && sponsorBlockSupport.value) {
-      final spbAudioSource =
-          await checkIfSponsorBlockIsAvailable(audioSource, song['ytid']);
-      return spbAudioSource ?? audioSource;
+    if (isOffline || !sponsorBlockSupport.value) {
+      return audioSource;
     }
 
-    return audioSource;
+    final spbAudioSource =
+        await checkIfSponsorBlockIsAvailable(audioSource, song['ytid']);
+    return spbAudioSource ?? audioSource;
   }
 
   Future<ClippingAudioSource?> checkIfSponsorBlockIsAvailable(