Dockerfile uses poetry in development and no venv in production #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niquerio
force-pushed
the
dockerfile-changes
branch
from
4c9e747 to
bcccc95
Compare
niquerio
requested review from
liseli,
antmoth,
Ronster2018,
ssciolla and
jayamala17
ssciolla
reviewed
Nov 21, 2024
| ENV PYTHONUNBUFFERED=1 | ||
|
|
||
| # Extend the socket timeout. Default would be 15s | ||
| ENV PIP_DEFAULT_TIMEOUT=100 |
There was a problem hiding this comment.
Suggested change
| ENV PIP_DEFAULT_TIMEOUT=100 | |
| ENV PIP_DEFAULT_TIMEOUT=100 |
Comment on lines
+22
to
+23
| # RUN apt-get update -yqq && apt-get install -yqq --no-install-recommends \ | ||
| # vim-tiny |
There was a problem hiding this comment.
Should this be removed? Or do we want to add a comment explaining this is how to add packages if you need them?
Comment on lines
+68
to
+69
| # RUN apt-get update -yqq && apt-get install -yqq --no-install-recommends \ | ||
| # wget\ |
|
|
||
| # Setting this to 'off' actually turns off the cache. This is set to decrease | ||
| # the size of the image. | ||
| ENV PIP_NO_CACHE_DIR=off |
There was a problem hiding this comment.
Suggested change
| ENV PIP_NO_CACHE_DIR=off | |
| ENV PIP_NO_CACHE_DIR=off |
| ENV PIP_NO_CACHE_DIR=off | ||
|
|
||
| # Speed up pip usage by not checking for the version | ||
| ENV PIP_DISABLE_PIP_VERSION_CHECK=on |
There was a problem hiding this comment.
Suggested change
| ENV PIP_DISABLE_PIP_VERSION_CHECK=on | |
| ENV PIP_DISABLE_PIP_VERSION_CHECK=on |
| COPY pyproject.toml poetry.lock README.md ./ | ||
| # Ensure that the virtual environment directory is in the project. This path | ||
| # will be be `/app/.venv/` | ||
| ENV POETRY_VIRTUALENVS_IN_PROJECT=1 |
There was a problem hiding this comment.
Suggested change
| ENV POETRY_VIRTUALENVS_IN_PROJECT=1 | |
| ENV POETRY_VIRTUALENVS_IN_PROJECT=1 |
| # Set up our final runtime layer | ||
| FROM python:3.11-slim-bookworm as runtime | ||
| # Create the virtual environment if it does not already exist | ||
| ENV POETRY_VIRTUALENVS_CREATE=1 |
There was a problem hiding this comment.
Suggested change
| ENV POETRY_VIRTUALENVS_CREATE=1 | |
| ENV POETRY_VIRTUALENVS_CREATE=1 |
* Changes Docker structure so that there is poetry in the development step, and pip in the production step * Cleands up the documentation in the dockerfile * Adds some directories and filenames to .gitignore and .dockerignore * init.sh has shellcheck improvements and installs python packages
niquerio
force-pushed
the
dockerfile-changes
branch
from
bcccc95 to
b9eca9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerfile now has poetry in the
developmentstage, meaning one can install packages with poetry in the container, and one does not have to have poetry installed locally.The
productionstage runspip installon therequirements.txtgenerated by poetry in thebuildstage.The
init.shscript hasshellcheckimprovements, and adds installing poetry packages.