-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create mlflow run for DSPy compile #14949
Conversation
Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>
Documentation preview for f9e2270 will be available when this CircleCI job
More info
|
Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>
Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>
Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@@ -37,6 +53,7 @@ def set_dependencies_schema(self, dependencies_schema: dict[str, Any]): | |||
) | |||
self._dependencies_schema = dependencies_schema | |||
|
|||
@skip_if_trace_disabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for me to understand - why do we need a second level of protection? I think we are controlling through autolog()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We changed the bahavior of autolog so that we include the callback even when log_trace is off. Therefore, we need to add this protection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotcha, correct me if I am wrong - my read is you want to allow users to only track compile()
call, in which scenario we will only log to mlflow at the Evaluator.__call__
hook?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the evaluation callback will have additional logging for optimization progression when called within compile
mlflow/dspy/callback.py
Outdated
@@ -28,6 +42,8 @@ def __init__(self, dependencies_schema: Optional[dict[str, Any]] = None): | |||
self._dependencies_schema = dependencies_schema | |||
# call_id: (LiveSpan, OTel token) | |||
self._call_id_to_span: dict[str, SpanWithToken] = {} | |||
# used to determine the behavior of the evaluation callback | |||
self._within_compile = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems this is not used in this PR? Could you help me understand the role of this variable? Are we going to use it to determine if evaluate should be put under a nested mlflow run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this attribute will be used to determine if the stack is in the compile process or not. We will have some custom logic in the evaluation when it's inside a compile.
Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>
6876a31
to
f9e2270
Compare
Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>
Signed-off-by: Tomu Hirata <tomu.hirata@gmail.com>
🛠 DevTools 🛠
Install mlflow from this PR
For Databricks, use the following command:
Related Issues/PRs
N/A
What changes are proposed in this pull request?
This PR introduces new options to DSPy autologging:
log_compiles
: create a run for each optimization and log program paramslog_models
: log models when an optimizer is calledHow is this PR tested?
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
When mlflow.dspy.autolog is called with
log_compiles
, a mlflow run is created and program params are logged.What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/deployments
: MLflow Deployments client APIs, server, and third-party Deployments integrationsarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/recipes
: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notesShould this PR be included in the next patch release?
Yes
should be selected for bug fixes, documentation updates, and other small changes.No
should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.What is a minor/patch release?
Bug fixes, doc updates and new features usually go into minor releases.
Bug fixes and doc updates usually go into patch releases.