Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actor Feed Loaders #1434

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Actor Feed Loaders #1434

wants to merge 8 commits into from

Conversation

EricBAndrews
Copy link
Member

Frontend changes for the real PR.

Contains two minor changes of note:

  • EndOfFeedView can now take in an optional loadMore callback; if available, a "Load More" button will be rendered at the bottom of the feed if the loadingState is idle. Sometimes hiding read posts creates a feed that won't trigger the infinite load; this handles that case without needing to do weird threshold hacks. This will also make implementing Disable Infinite Scrolling Option #832 trivial.
  • loadFeed now triggers if the loader is empty regardless of loadingState. The middleware PR changes the initial loadingState to be .loading, which in turn results in a spinner being immediately rendered when an empty feed is opened.

@EricBAndrews EricBAndrews requested a review from a team as a code owner November 13, 2024 23:31
@EricBAndrews EricBAndrews requested review from WestonHanners, JakeShirley and Sjmarf and removed request for a team November 13, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant