Fix check_model: LLM_MODELS is a list of str, not Enum (#317)#321
Merged
idevasena merged 1 commit intomlcommons:mainfrom Apr 9, 2026
Merged
Fix check_model: LLM_MODELS is a list of str, not Enum (#317)#321idevasena merged 1 commit intomlcommons:mainfrom
idevasena merged 1 commit intomlcommons:mainfrom
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
FileSystemGuy
approved these changes
Apr 7, 2026
russfellows
approved these changes
Apr 9, 2026
Contributor
russfellows
left a comment
There was a problem hiding this comment.
Looks like this has been tested, great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running
mlpstorage checkpointing datasizewith any valid model (e.g.--model llama3-8b) fails with:Root Cause
In
mlpstorage_py/rules/run_checkers/checkpointing.py, line 34 treatsLLM_MODELSentries as Enum members:However,
LLM_MODELS(defined inconfig.py) is a plain list of strings, not an Enum. Calling.valueon astrraises anAttributeError.Fix
Replace the list comprehension with a direct reference since the values are already strings:
Testing
mlpstorage checkpointing datasize --model llama3-8b ...no longer crashes.