[WIP] Web UI dataset #617

VukW · 2024-09-16T16:17:33Z

depends on #606
Adds functionality for creating & managing datasets

Dataset submission

Submitted dataset displaying (dataset details page)

p2 display paths (data path, labels path)
p1 display dataset statistics

Dataset preparation

Prepared dataset displaying (dataset details page)

p2 if report exists, "Allowed automatic report submission" flag
p2 if report exists, link / path to the report
p1 if dataset is prepared, unlock next button "set operational" (locked if not prepared)

Set operational

p0 "Set operational" button on dataset detail page
p0 Set operational
p0 Disable button if already operational
p1 check how errors are displayed & handled

Associate

p1 "Associate with the benchmark" button on the dataset detail page (no choice of benchmarks)
p3 choice of benchmarks if dataset was created with dataprep mlcube
p1 associate
p1 check how errors are displayed & handled

Run benchmark

Submit result

p1 "Submit result" button on the dataset detail page
p1 Submit result
p1 check how errors are displayed & handled
p2 "Submit all" button

general dataset UI

p2 design buttons prepare-operational-... navigation to one line?
p1 hide buttons panel if you're not the dataset owner?
p3 redesign state displaying (we'd have dev/op floating blocks in the header + set-op button in the footer)

Technical refactoring

p1 split routes to different files: dataset/submission.py, dataset/preparation.py

github-actions · 2024-09-16T16:17:50Z

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

VukW · 2024-09-17T10:35:09Z

cli/medperf/web_ui/api/routes.py

+    full_path = os.path.join(BASE_DIR, path)
+    os.path.join(BASE_DIR, path)
+
+    if not os.path.exists(full_path) or not os.path.isdir(full_path):


This function lists all files and folders on the server side. So, yes, it is expected to use user's given path to list its content (though still may be dangerous? I don't know)

We should handle all of these vulnerabilities as suggested, even if they're expected to be for local calls or not

cli/medperf/web_ui/api/routes.py

+    full_path = os.path.join(BASE_DIR, path)
+    os.path.join(BASE_DIR, path)
+
+    if not os.path.exists(full_path) or not os.path.isdir(full_path):


cli/medperf/web_ui/api/routes.py

+
+    # List directories inside the path
+    folders = []
+    for item in os.listdir(full_path):


cli/medperf/web_ui/api/routes.py

+    folders = []
+    for item in os.listdir(full_path):
+        item_path = os.path.join(full_path, item)
+        if os.path.isdir(item_path):


cli/medperf/web_ui/yaml_fetch/routes.py

cli/medperf/web_ui/datasets/routes.py

# Conflicts: # cli/medperf/web_ui/yaml_fetch/routes.py

… not updated)

cli/medperf/web_ui/login.py

+    # Check if user is already authenticated
+    if token == security_token:
+        # User is already authenticated, redirect to original URL
+        return RedirectResponse(url=redirect_url, status_code=status.HTTP_302_FOUND)


cli/medperf/web_ui/login.py

+        redirect_url: str = Form("/"),
+):
+    if token == security_token:
+        response = RedirectResponse(url=redirect_url, status_code=status.HTTP_302_FOUND)


cli/medperf/web_ui/login.py

+):
+    if token == security_token:
+        response = RedirectResponse(url=redirect_url, status_code=status.HTTP_302_FOUND)
+        response.set_cookie(key=AUTH_COOKIE_NAME, value=token)


cli/medperf/web_ui/login.py

+):
+    if token == security_token:
+        response = RedirectResponse(url=redirect_url, status_code=status.HTTP_302_FOUND)
+        response.set_cookie(key=AUTH_COOKIE_NAME, value=token)


aristizabal95

This was a ton of work! There are a few suggestions on maintaining style, and covering vulnerabilities with the suggestions generated by github would be ideal. Also, this work should prompt some discussion on the current design and future design, since this implementation could not be added without repeating code. Leaving as is could lead to several bugs if changes need to be done in the current workflow (as they would need to be implemented in both CLI and Web UI). This is some amazing work for a task that was very intimidating and difficult to define

aristizabal95 · 2024-12-16T20:04:13Z

cli/medperf/commands/dataset/submit.py

+            + " Owner for traceability and debugging purposes."
+        )
+        config.ui.print_warning(warning)
+        preparation.approved = preparation.approved or approval_prompt(msg)


It would be better to instead convert this logic into a function, and keep the original flow with the added new function. Just so that we keep a consistent style where you can get an idea of the workflow of a command by looking at the run function.

aristizabal95 · 2024-12-16T20:07:24Z

cli/medperf/commands/result/create.py

@@ -1,4 +1,5 @@
 import os
+import time


This dependency doesn't appear to be needed

aristizabal95 · 2024-12-16T20:11:16Z

cli/medperf/web_ui/api/routes.py

+    full_path = os.path.join(BASE_DIR, path)
+    os.path.join(BASE_DIR, path)
+
+    if not os.path.exists(full_path) or not os.path.isdir(full_path):


We should handle all of these vulnerabilities as suggested, even if they're expected to be for local calls or not

aristizabal95 · 2024-12-16T20:25:22Z

cli/medperf/web_ui/datasets/routes_associate.py

+    """
+    dataset = Dataset.get(dataset_id)
+    benchmark = Benchmark.get(benchmark_id)
+    draft_id = str(uuid.uuid4())


Didn't know of this. Nice!

VukW added 2 commits September 10, 2024 12:17

Dataset creation step 1

f2f25c0

Dataset submission wizard

4da2628

VukW requested a review from a team as a code owner September 16, 2024 16:17

VukW had a problem deploying to testing-external-code September 16, 2024 16:17 — with GitHub Actions Failure

github-advanced-security bot found potential problems Sep 16, 2024

View reviewed changes

Merge branch 'web-ui' into web-ui-dataset

64f26ff

VukW had a problem deploying to testing-external-code September 17, 2024 10:30 — with GitHub Actions Failure

Linter fix

14f87a9

VukW had a problem deploying to testing-external-code September 17, 2024 10:37 — with GitHub Actions Failure

Almost added dataset prepare

812cd7e

VukW had a problem deploying to testing-external-code September 24, 2024 13:44 — with GitHub Actions Failure

VukW changed the title ~~Web UI dataset~~ [WIP] Web UI dataset Sep 24, 2024

VukW added 2 commits September 25, 2024 13:25

Added set-operational functionality

7f86b1b

Handling set-op errors (unsuccessful)

cfcf9df

VukW had a problem deploying to testing-external-code September 25, 2024 18:37 — with GitHub Actions Failure

github-advanced-security bot found potential problems Sep 25, 2024

View reviewed changes

cli/medperf/web_ui/datasets/routes.py Fixed Show fixed Hide fixed

VukW added 2 commits September 30, 2024 18:59

Handling set-op errors

08f2ca7

Displaying preparation logs in a beauty way

04f8c11

VukW had a problem deploying to testing-external-code October 2, 2024 17:06 — with GitHub Actions Failure

github-advanced-security bot found potential problems Oct 2, 2024

View reviewed changes

cli/medperf/web_ui/datasets/routes.py Fixed Show fixed Hide fixed

refactored dataset routes

d617a04

VukW had a problem deploying to testing-external-code October 4, 2024 16:30 — with GitHub Actions Failure

VukW added 2 commits October 6, 2024 12:52

Associate dataset with the benchmark

1bd0926

Association: choose benchmark

f38a6ab

VukW had a problem deploying to testing-external-code October 7, 2024 15:11 — with GitHub Actions Failure

VukW added 2 commits October 8, 2024 17:22

Unified page name

f0769b2

Merge remote-tracking branch 'personal/web-ui' into web-ui-dataset

015354e

# Conflicts: # cli/medperf/web_ui/yaml_fetch/routes.py

VukW had a problem deploying to testing-external-code October 9, 2024 14:15 — with GitHub Actions Failure

Added dataset report + refactored yaml panel styles

96362de

VukW added 4 commits October 14, 2024 18:06

Backend for running bmk over dataset in background

43d2b77

Added FE for model run

75f9c5c

bugfix: mark last stage as completed also

f2ddd62

Redesigned dataset run page

df0e2c2

VukW had a problem deploying to testing-external-code October 15, 2024 15:47 — with GitHub Actions Failure

VukW added 2 commits October 15, 2024 19:25

bugfix

e082cec

Restyled model list

4926f07

VukW had a problem deploying to testing-external-code October 15, 2024 16:29 — with GitHub Actions Failure

VukW added 2 commits October 15, 2024 21:30

Updated models list layout

4b45f49

Restyled models list

35ded73

VukW had a problem deploying to testing-external-code October 15, 2024 19:12 — with GitHub Actions Failure

VukW added 6 commits October 16, 2024 18:45

Restyled the run buttons

2ab585d

Added "Running" state

a7fdd52

"Run all" button

d9d2932

removed unused code

397aed4

minor bugfixes

7780bc0

Result submission

7d20e31

VukW had a problem deploying to testing-external-code October 22, 2024 14:52 — with GitHub Actions Failure

bugfix: status was passed wrongly if result is submitted (as draft is…

2a1d55d

… not updated)

VukW had a problem deploying to testing-external-code October 22, 2024 15:37 — with GitHub Actions Failure

Auth by security token

48e388e

VukW had a problem deploying to testing-external-code October 24, 2024 13:58 — with GitHub Actions Failure

github-advanced-security bot found potential problems Oct 24, 2024

View reviewed changes

Restyled dataset pipeline buttons

23908f5

VukW had a problem deploying to testing-external-code October 24, 2024 15:05 — with GitHub Actions Failure

aristizabal95 changed the base branch from main to web-ui December 16, 2024 17:10

aristizabal95 added the topic: UI/UX label Dec 16, 2024

aristizabal95 approved these changes Dec 16, 2024

View reviewed changes

hasan7n merged commit 020da3e into mlcommons:web-ui Dec 21, 2024
3 of 8 checks passed

github-actions bot locked and limited conversation to collaborators Dec 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[WIP] Web UI dataset #617

[WIP] Web UI dataset #617

Uh oh!

VukW commented Sep 16, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Sep 16, 2024 •

edited

Loading

Uh oh!

Check failure

VukW Sep 17, 2024

Uh oh!

aristizabal95 Dec 16, 2024

Uh oh!

Check failure

Check failure

Check failure

Uh oh!

Uh oh!

Uh oh!

Check warning

Check warning

Check warning

Check warning

aristizabal95 left a comment

Uh oh!

aristizabal95 Dec 16, 2024

Uh oh!

aristizabal95 Dec 16, 2024

Uh oh!

aristizabal95 Dec 16, 2024

Uh oh!

aristizabal95 Dec 16, 2024

Uh oh!

Uh oh!

Uh oh!

[WIP] Web UI dataset #617

[WIP] Web UI dataset #617

Uh oh!

Conversation

VukW commented Sep 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dataset submission

Submitted dataset displaying (dataset details page)

Dataset preparation

Prepared dataset displaying (dataset details page)

Set operational

Associate

Run benchmark

Submit result

general dataset UI

Technical refactoring

Uh oh!

github-actions bot commented Sep 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Check failure

Uh oh!

VukW Sep 17, 2024

Choose a reason for hiding this comment

Uh oh!

aristizabal95 Dec 16, 2024

Choose a reason for hiding this comment

Uh oh!

Check failure

Uh oh!

Check failure

Uh oh!

Check failure

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check warning

Uh oh!

Check warning

Uh oh!

Check warning

Check warning

Uh oh!

aristizabal95 left a comment

Choose a reason for hiding this comment

Uh oh!

aristizabal95 Dec 16, 2024

Choose a reason for hiding this comment

Uh oh!

aristizabal95 Dec 16, 2024

Choose a reason for hiding this comment

Uh oh!

aristizabal95 Dec 16, 2024

Choose a reason for hiding this comment

Uh oh!

aristizabal95 Dec 16, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

VukW commented Sep 16, 2024 •

edited

Loading

github-actions bot commented Sep 16, 2024 •

edited

Loading