-
Notifications
You must be signed in to change notification settings - Fork 36
package installation in non-editable mode: pip install ./cli
#550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
@@ -1,16 +1,13 @@ | |||
from ._version import __version__ | |||
from pathlib import Path | |||
|
|||
BASE_DIR = Path(__file__).resolve().parent.parent.parent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BASE_DIR
has no sense when client is installed in standard way (as it points somewhere to /your/path/to/python/env/lib/site-packages/
)
pip install ./cli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Although I think some discussion has to be made regarding the local server set up. Local servers are mainly for development/testing purposes, and having it packaged with the medperf client doesn't feel right.
At this point there's no easy way to set up a local server without having to go to the package folder and running the provided sh scripts. This doesn't feel like something every user needs to do and so it probably shouldn't get packaged with our installation.
This does require a lot of thinking and modifications to our resources, so it's no small decision to make. Let's have a chat soon about this!
Folks, I'm thinking. Do we need to pack local server to the pip package at all? I mean, it is used only for development purposes. What do you think if we leave it in a repo? so every developer who needs local server would have to check out repo. |
# Conflicts: # cli/medperf/utils.py # cli/requirements.txt # server/setup-dev-server.sh
TODO:
|
# Conflicts: # cli/medperf/cli.py # cli/medperf/utils.py # cli/requirements.txt
The goal is to make medperf client installable from pypi. This PR is the first part that allows installing package not from repository
A few changes were implemented:
cert.crt
,cert.key
andmock_tokens/tokens.json
to~/.medperf_config/.local_server/
so detached medperf client can use it. NB: this change breaks the behavior for existing developers (as path to local server cert is already defined in user config). You should update local config'scertificate
path to~/.medperf_config/.local_server/cert.crt
.pip install -e ./cli
replaced withpip install ./cli
everywhere