Skip to content

Conversation

pgmpablo157321
Copy link
Contributor

fix #2007

@pgmpablo157321 pgmpablo157321 requested a review from a team as a code owner January 14, 2025 04:10
Copy link
Contributor

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@arjunsuresh
Copy link
Contributor

Thank you @pgmpablo157321 for the fix.

Can you please answer this question on effective_samples_per_query? For the benchmarks with equal_issue_mode, the effective_samples_per_query must be a multiple of the dataset size right? But in the previously submitted logs this is not the case. May be loadgen is not populating this value correctly?

https://github.com/mlcommons/inference_results_v4.1/blob/30d19b768aed8d9894307050039ccecdfae8b479/closed/NVIDIA/results/H200-SXM-141GBx8_TRT_MaxQ/mixtral-8x7b/Offline/performance/run_1/mlperf_log_detail.txt#L35

@mrmhodak mrmhodak merged commit 1f73d4c into master Jan 14, 2025
19 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

R-GAT reference implementation is giving the below warning related to numpy array being non-writable.

3 participants