Skip to content

[fix] Fix example 01 - logger arg#167

Merged
arekay-nv merged 1 commit intomainfrom
arekay/fix_example_01
Mar 12, 2026
Merged

[fix] Fix example 01 - logger arg#167
arekay-nv merged 1 commit intomainfrom
arekay/fix_example_01

Conversation

@arekay-nv
Copy link
Copy Markdown
Collaborator

What does this PR do?

Fixes example 01 which runs a tinyllama model.

Type of change

  • Bug fix
  • New feature
  • Documentation update
  • Refactor/cleanup

Related issues

Testing

  • Tests added/updated
  • All tests pass locally
  • Manual testing completed

Checklist

  • Code follows project style
  • Pre-commit hooks pass
  • Documentation updated (if needed)

Signed-off-by: Rashid Kaleem <230885705+arekay-nv@users.noreply.github.com>
@arekay-nv arekay-nv requested a review from a team as a code owner March 12, 2026 04:06
Copilot AI review requested due to automatic review settings March 12, 2026 04:06
@github-actions
Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@github-actions github-actions bot requested a review from nvzhihanj March 12, 2026 04:06
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a bug in example 01, which demonstrates running a TinyLLM model. The fix ensures consistency between a command-line argument and its corresponding internal parameter, clarifying that event data is logged rather than saved as a CSV, thereby improving the example's accuracy and functionality.

Highlights

  • Command-line argument renamed: The command-line argument --dump-events-csv was renamed to --dump-events-log to accurately reflect that events are dumped to a log file, not a CSV.
  • Parameter updated: The dump_events_csv parameter in the BenchmarkSession constructor was updated to dump_events_log to align with the renamed command-line argument.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • examples/01_LocalBenchmark/run_tinyllm.py
    • Renamed the command-line argument --dump-events-csv to --dump-events-log.
    • Updated the BenchmarkSession constructor call to use dump_events_log instead of dump_events_csv.
Activity
  • No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a bug in example 01 where the CLI argument --dump-events-csv and its corresponding usage were out of sync with the API, renaming them to --dump-events-log/dump_events_log.

Changes:

  • Renamed --dump-events-csv argument to --dump-events-log and updated its help text and usage accordingly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the run_tinyllm.py example script to use the correct argument for dumping event logs. The command-line argument is changed from --dump-events-csv to --dump-events-log, and the corresponding keyword argument passed to BenchmarkSession.start is updated from dump_events_csv to dump_events_log. This aligns the example with the BenchmarkSession.start method signature, which expects dump_events_log to control dumping events to a JSONL file, resolving a runtime error.

@arekay-nv arekay-nv merged commit 8a85041 into main Mar 12, 2026
9 of 10 checks passed
@arekay-nv arekay-nv deleted the arekay/fix_example_01 branch March 12, 2026 04:21
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants