Conversation
Signed-off-by: Rashid Kaleem <230885705+arekay-nv@users.noreply.github.com>
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a bug in example 01, which demonstrates running a TinyLLM model. The fix ensures consistency between a command-line argument and its corresponding internal parameter, clarifying that event data is logged rather than saved as a CSV, thereby improving the example's accuracy and functionality. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull request overview
Fixes a bug in example 01 where the CLI argument --dump-events-csv and its corresponding usage were out of sync with the API, renaming them to --dump-events-log/dump_events_log.
Changes:
- Renamed
--dump-events-csvargument to--dump-events-logand updated its help text and usage accordingly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Code Review
This pull request updates the run_tinyllm.py example script to use the correct argument for dumping event logs. The command-line argument is changed from --dump-events-csv to --dump-events-log, and the corresponding keyword argument passed to BenchmarkSession.start is updated from dump_events_csv to dump_events_log. This aligns the example with the BenchmarkSession.start method signature, which expects dump_events_log to control dumping events to a JSONL file, resolving a runtime error.
What does this PR do?
Fixes example 01 which runs a tinyllama model.
Type of change
Related issues
Testing
Checklist