Open
Conversation
as implemented in mlcommons#932
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
benjelloun
reviewed
Dec 3, 2025
Contributor
benjelloun
left a comment
benjelloun
left a comment
There was a problem hiding this comment.
Sorry for the slow turn-around!
|
|
||
| ```json | ||
| "description": { | ||
| "en": "The date the photo was taken.", |
Contributor
There was a problem hiding this comment.
I would prefer not to use a language map in the example, so that we don't change the default Croissant context. This is because our library implementation depends on the context being stable (which is not correct, but would require a significant effort to fix).
Contributor
Author
There was a problem hiding this comment.
Is the library implementation the python library? I made changes to the context used in #932 so that this feature would work, what does it mean that the default context can't be changed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small example at the end of the Format Example section demonstrating how to represent multilingual values as implemented in #932
Also update the context Appendix to allow parsing name and description fields in this format in JSON-LD.