Updates to the Croissant turtle definition to align with the spec, and… #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… introduce ML-specific constructs.
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
|
@marcenacp @ccl-core can you pls take a look at this PR? Thanks! |
marcenacp
approved these changes
Apr 23, 2024
| croissant:BoundingBox a rdf:class ; | ||
| rdfs:label "Label" ; | ||
| rdfs:comment "A data type representing a bounding box." ; | ||
| rdfs:subClassOf schema:Text . |
There was a problem hiding this comment.
schema: StructuredValue instead of schema: Text?
There was a problem hiding this comment.
Hmm... I'm not sure, because we're providing the values as a single string, and not as a set of properties.
In fact there is already schema.org/GeoShape, with a "box" property of type Text. It's cumbersome to use directly in Croissant because it's a property and not a class.
| croissant:Label a rdf:class ; | ||
| rdfs:label "Label" ; | ||
| rdfs:comment "A machine learning label." ; | ||
| rdfs:subClassOf schema:Intangible . |
There was a problem hiding this comment.
Can it still be used even if it's Intangible?
There was a problem hiding this comment.
Yes, see https://schema.org/Intangible for other examples of Intangible subclasses.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… introduce ML-specific constructs.