Issue #542 - folder structure rearrange - submission generation #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- user.conf and measurements.json to the scenario folder - system_meta.json to root folder
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
arjunsuresh
reviewed
Nov 19, 2024
|
|
||
| user_conf_path = os.path.join(result_scenario_path, "user.conf") | ||
|
|
||
| measurements_json_path = os.path.join(result_scenario_path, "measurements.json") |
Contributor
There was a problem hiding this comment.
It is better to move this code to near line number 422 to avoid redundancy.
arjunsuresh
reviewed
Nov 19, 2024
| shutil.copy(measurements_json_path, os.path.join(target_measurement_json_path, sub_res+'.json')) | ||
| shutil.copy(measurements_json_path, os.path.join(target_measurement_json_path, 'model-info.json')) | ||
| else: | ||
| if not mode.startswith("TEST"): |
Contributor
There was a problem hiding this comment.
we should error out only in performance mode right?
arjunsuresh
reviewed
Nov 19, 2024
| # This line can be removed once the PR in the inference repo is merged. | ||
| shutil.copy(measurements_json_path, os.path.join(submission_measurement_path, sub_res+'.json')) | ||
| shutil.copy(measurements_json_path, os.path.join(submission_measurement_path, 'model-info.json')) | ||
| shutil.copy(measurements_json_path, os.path.join(target_measurement_json_path, sub_res+'.json')) |
Contributor
There was a problem hiding this comment.
PR is merged. So, we can remove this line
arjunsuresh
reviewed
Nov 19, 2024
| if not all([os.path.exists(os.path.join(result_scenario_path, "performance", "run_1", f)) for f in files_to_check]): | ||
| continue | ||
|
|
||
| if not os.path.isdir(measurement_scenario_path): |
Contributor
Author
There was a problem hiding this comment.
Hi @arjunsuresh , i have placed it above the for loop as submission_measurement_path and measurement_scenario_path are the same.
arjunsuresh
reviewed
Nov 19, 2024
| tags: _short-run | ||
| env: | ||
| CM_MLPERF_SUBMISSION_DIVISION: open | ||
| CM_RUN_MLPERF_SUBMISSION_PREPROCESSOR: off |
Contributor
There was a problem hiding this comment.
Theres already an env in this variation
Contributor
Author
There was a problem hiding this comment.
missed due to space in between... fixed:)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.