Enables docker run in inference submission generation #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
arjunsuresh
reviewed
Nov 5, 2024
script/tar-my-folder/customize.py
Outdated
| if input_dir == "": | ||
| return {'return': 1, 'error': 'Please set CM_TAR_INPUT_DIR'} | ||
| output_dir = env.get("CM_TAR_OUTPUT_DIR", "") | ||
| output_dir = env.get("CM_MLPERF_INFERENCE_SUBMISSION_BASE_DIR", env.get("CM_TAR_OUTPUT_DIR", "")) |
Contributor
There was a problem hiding this comment.
We should pass this env from the submission generation script. tar-my-folder CM script should not know anything specific about submission generation.
arjunsuresh
reviewed
Nov 5, 2024
| "CM_MLPERF_INFERENCE_SUBMISSION_BASE_DIR": [ | ||
| "on" | ||
| ], | ||
| "CM_MLPERF_INFERENCE_SUBMISSION_DIR": [ |
Contributor
There was a problem hiding this comment.
if submission_dir is passed but not submission_base_dir, will the code work?
arjunsuresh
reviewed
Nov 5, 2024
| "cm pull repo" | ||
| ], | ||
| "mounts": [ | ||
| "${{ CM_MLPERF_INFERENCE_SUBMISSION_DIR }}:${{ CM_MLPERF_INFERENCE_SUBMISSION_DIR }}", |
arjunsuresh
reviewed
Nov 5, 2024
| "${{ CM_MLPERF_INFERENCE_SUBMISSION_BASE_DIR }}:${{ CM_MLPERF_INFERENCE_SUBMISSION_BASE_DIR }}", | ||
| "${{ CM_MLPERF_INFERENCE_RESULTS_DIR_ }}:${{ CM_MLPERF_INFERENCE_RESULTS_DIR_ }}" | ||
| ], | ||
| "extra_run_args": " --ulimit memlock=-1 --cap-add SYS_ADMIN --cap-add SYS_TIME --security-opt apparmor=unconfined --security-opt seccomp=unconfined", |
arjunsuresh
approved these changes
Nov 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.