Skip to content

Conversation

@anandhu-eng
Copy link
Contributor

No description provided.

@anandhu-eng anandhu-eng requested a review from a team as a code owner November 4, 2024 17:09
@github-actions
Copy link

github-actions bot commented Nov 4, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@anandhu-eng anandhu-eng marked this pull request as draft November 4, 2024 17:20
python-version: "3.8"
include:
- os: windows-latest
docker: ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cant we install docker on windows non interactively?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arjunsuresh , there is command line installation method for windows in official docker website. Mybe with some workaround its possible?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works but only for Windows docker images which CM does not support currently.

attempt=1
docker --version
docker info
while ! docker --version > /dev/null 2>&1; do
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @arjunsuresh , I think we are able to successfully obtain the output of docker --version even though docker daemon is not running, just docker needs to be installed.

- name: Start Docker Daemon on macos
if: runner.os == 'macOS-deactivated'
run: |
open /Applications/Docker.app
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the docker application starts up for the first time, it asks for accepting the aggreements then only proceeds to starting the docker daemon. Maybe we have to find some better way?
Screenshot from 2024-11-06 18-52-23

@anandhu-eng anandhu-eng marked this pull request as ready for review November 6, 2024 13:36
@arjunsuresh arjunsuresh merged commit c39d8e0 into mlperf-inference Nov 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants