Skip to content

Do not pass mlperf_conf for inference-src >= 4.1.1 #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arjunsuresh merged 3 commits into from
Oct 21, 2024
Merged

Do not pass mlperf_conf for inference-src >= 4.1.1 #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dde1596
Do not pass mlperf_conf for the reference implementation if version >…
arjunsuresh Oct 21, 2024
799c80f
Merge branch 'mlcommons:mlperf-inference' into mlperf-inference
arjunsuresh Oct 21, 2024
6d0f663
Fix syntax
arjunsuresh Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions script/app-mlperf-inference-mlcommons-python/customize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,15 @@ def preprocess(i):


x="" if os_info['platform'] == 'windows' else "'"
if "llama2-70b" in env['CM_MODEL'] or "mixtral-8x7b" in env["CM_MODEL"]:
env['CM_MLPERF_LOADGEN_EXTRA_OPTIONS'] += " --mlperf-conf " + x+ env['CM_MLPERF_CONF'] + x

inference_src_version = env.get('CM_MLPERF_INFERENCE_SOURCE_VERSION', '')
if inference_src_version and inference_src_version >= (4,1,1):
pass # mlperf_conf is automatically loaded by the loadgen
else:
env['CM_MLPERF_LOADGEN_EXTRA_OPTIONS'] += " --mlperf_conf "+ x + env['CM_MLPERF_CONF'] + x
if "llama2-70b" in env['CM_MODEL'] or "mixtral-8x7b" in env["CM_MODEL"]:
env['CM_MLPERF_LOADGEN_EXTRA_OPTIONS'] += " --mlperf-conf " + x+ env['CM_MLPERF_CONF'] + x
else:
env['CM_MLPERF_LOADGEN_EXTRA_OPTIONS'] += " --mlperf_conf "+ x + env['CM_MLPERF_CONF'] + x

if env.get('CM_NETWORK_LOADGEN', '') != "lon" and env.get('CM_MLPERF_INFERENCE_API_SERVER','')=='' and "llama2-70b" not in env['CM_MODEL']:
env['MODEL_DIR'] = env.get('CM_ML_MODEL_PATH')
Expand Down
2 changes: 1 addition & 1 deletion script/get-mlperf-inference-src/customize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def postprocess(i):
env['+PYTHONPATH'].append(os.path.join(env['CM_MLPERF_INFERENCE_CLASSIFICATION_AND_DETECTION_PATH'], 'python'))

if os.path.exists(os.path.join(inference_root, "loadgen", "VERSION")):
with open(os.path.join(inference_root, "loadgen", "VERSION") as f:
with open(os.path.join(inference_root, "loadgen", "VERSION")) as f:
version_info = f.read()
env['CM_MLPERF_INFERENCE_SOURCE_VERSION'] = version_info

Expand Down