Skip to content

various updates for CM tools for Windows and better debugging#316

Merged
gfursin merged 27 commits intomainfrom
dev
Oct 2, 2024
Merged

various updates for CM tools for Windows and better debugging#316
gfursin merged 27 commits intomainfrom
dev

Conversation

@gfursin
Copy link
Contributor

@gfursin gfursin commented Oct 1, 2024

No description provided.

@gfursin gfursin requested a review from a team as a code owner October 1, 2024 12:36
@github-actions
Copy link

github-actions bot commented Oct 1, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@gfursin
Copy link
Contributor Author

gfursin commented Oct 1, 2024

@anandhu-eng - I updated Windows tools with the newest wget.exe as you suggested:

Grigori Fursin and others added 2 commits October 1, 2024 14:48
@gfursin gfursin requested a review from arjunsuresh October 1, 2024 12:54
@gfursin gfursin requested a review from anandhu-eng October 1, 2024 12:54
@gfursin
Copy link
Contributor Author

gfursin commented Oct 1, 2024

I turned on test on Windows to make sure that the core CM functionality is not broken.

@arjunsuresh
Copy link
Contributor

@gfursin Windows test won't work with MLPerf as the default workflow is doing llvm installation for loadgen build which works only with user interaction.

Grigori Fursin and others added 2 commits October 1, 2024 17:39
* added windows test for image classification
* removed windows test for MLPerf (requires interaction)
@gfursin
Copy link
Contributor Author

gfursin commented Oct 1, 2024

@gfursin Windows test won't work with MLPerf as the default workflow is doing llvm installation for loadgen build which works only with user interaction.

Oh, that's correct! Thanks @arjunsuresh! I removed windows test for MLPerf and added for python image-classification example with ONNX (it is my usual non-interactive test on Windows that touches many CM scripts).

@gfursin gfursin merged commit c4f69f6 into main Oct 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants