Removed old test files, fixed tests for script features and mlperf#1291
Removed old test files, fixed tests for script features and mlperf#1291gfursin merged 10 commits intomlcommons:masterfrom
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
gfursin
left a comment
gfursin
left a comment
There was a problem hiding this comment.
Interesting.
Actually, it seems that we still need all these tests here if we do changes in CM?
Is there a way to trigger cm4mlops tests if we do a change in this core CM repo?
Otherwise, if we remove all these tests, we will not be able to detect a problem with the main CM workflows when we update CM?
|
That's correct @gfursin . But currently these test files are not effective as they were supposed to run only when changes are made to "cm-mlops" directory. I think we should make separate test for testing CM scripts (no need for the whole MLPerf pipeline?) when CM core changes are made. |
I think it's still useful to test just 1 MLPerf pipeline here (no need for comprehensive MLPerf tests though) besides the code CM functionality just to avoid some obvious mistakes ;) ... |
arjunsuresh
changed the title
|
Sure @gfursin . I have added the script features test and also the R50 test. Currently some tests are failing on Windows and macOS which needs fix in the cm4mlops repository. |
|
Actually, I just saw the problem with certificates on Windows when downloading a dataset... Is it possible to fix it, please? Thanks! |
|
yes Grigori. That should be fixed in this PR |
2 participants
No description provided.