Skip to content

Comments

Setting Electricity mix and providers from config file#108

Merged
NP4567-dev merged 9 commits intomainfrom
feat/add_config
Feb 9, 2025
Merged

Setting Electricity mix and providers from config file#108
NP4567-dev merged 9 commits intomainfrom
feat/add_config

Conversation

@NP4567-dev
Copy link
Contributor

First part of using a file config as detailed in #98
For now it is just the basic case of setting provider and electricity mix zone.

Let me know if you want anything changed.

@adrienbanse
Copy link
Collaborator

@NP4567-dev I think you have to run a poetry lock

@adrienbanse
Copy link
Collaborator

I think there's a bigger problem than a poetry lock @NP4567-dev, my PR also fails: #104

Let me check this!

@adrienbanse
Copy link
Collaborator

@NP4567-dev It's fixed you can merge with the main

@NP4567-dev
Copy link
Contributor Author

@NP4567-dev It's fixed you can merge with the main

Nice,thank you for the fix!

@NP4567-dev NP4567-dev merged commit de34f2e into main Feb 9, 2025
2 checks passed
Copy link
Collaborator

@adrienbanse adrienbanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NP4567-dev Many thanks for this great contrib :)

Just next time I think it's safer to wait for a review to be done before merging (sorry if it wasn't clear, but I just added the CI comment without looking at the rest of the PR)

print(f"GHG emissions: {response.impacts.gwp.value} kgCO2eq")
```

You can also provide the ecologits configuration through a toml file.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we could add that it has to be in a [ecologits] section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sorry, I misinterpreted the "you can merge with main" 😅
I don't have access but in the settings -> branch rules you can block merges to main until there is at least one approval (owners can still bypass)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right my bad it had double sense :/
I'll change this in the settings thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants