Chores: remove team references #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inimaz
force-pushed
the
chores/remove-team
branch
from
5de143b
to
cb399f0
Compare
|
Seems like we can forget the current API version and dashboard and just go ahead and break it. |
SaboniAmine
reviewed
Jun 15, 2024
carbonserver/carbonserver/api/infra/repositories/repository_projects.py
Outdated
Show resolved
Hide resolved
carbonserver/carbonserver/database/alembic/versions/e4c304a52806_remove_teams.py
Outdated
Show resolved
Hide resolved
inimaz
commented
Jun 16, 2024
carbonserver/carbonserver/api/infra/repositories/repository_organizations.py
Show resolved
Hide resolved
Signed-off-by: inimaz <93inigo93@gmail.com>
prmths128
approved these changes
Jun 17, 2024
ah @prmths128 since we said we would do a dump, I understood it was not needed and I removed it dfef868 🤦♂️ I can do another PR and add it later if that's ok? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue ==> https://github.com/orgs/mlco2/projects/4/views/1?pane=issue&itemId=67355803
Goal is to remove the team to avoid too many dependencies. New structure will be:
Orga
User
TODO:
How to do a /v2 of the API without affecting the current dashboard? This PR will delete all references to teams in the db ==> it will break the dashboardNot applicable. We will create new db from scratch when release is ready.