CTL Tx Balancing & Coin Selection #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
marcusbfs
approved these changes
Apr 9, 2025
| txHasPlutusV1 :: Boolean | ||
| txHasPlutusV1 = | ||
| case p.transaction ^. _witnessSet <<< _plutusScripts of | ||
| case (unwrap (unwrap unbalancedTx).witnessSet).plutusScripts of |
Collaborator
There was a problem hiding this comment.
Is the change mainly for readability, or does it have performance implications as well?
Member
Author
There was a problem hiding this comment.
Not sure about performance, but I think we should avoid using lenses for such simple expressions to not overcomplicate the code
Collaborator
|
@errfrom also, would it be worth introducing a newtype |
Member
Author
|
@marcusbfs We've actually had this wrapper before, and it always came down to balancing type safety with ease of use. I believe we chose to prioritise the latter, so I'd leave it as is for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.