Fix "OutputZeroAda" bug and WalletApiError errors. #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmrocze
force-pushed
the
karol/error-messages
branch
from
b2d039f to
5db75f0
Compare
mikekeke
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small remarks:
WalletAPIErrorTypes #141 , but it's completely new commit. I couldn't revert the revert, so I wrote it againWalletApiErrortype is very much mismatched to our bpi errors, mostly we throw OtherError stillWalletAPIErrorTypes #141 also included a fix for Misleading error when minting value is 0 #71 (throwing one more error when list empty) - this fix is now unneeded as the fixedcalculateMinUtxowas removed inbfadce0. Balancing outputs with min ada is now handled without cli calls.