Skip to content
This repository was archived by the owner on Nov 15, 2022. It is now read-only.

Adding Gen types for ScriptContexts #41

Open
jhodgdev wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Adding Gen types for ScriptContexts #41

jhodgdev wants to merge 27 commits into from

Conversation

@jhodgdev
Copy link
Contributor

@jhodgdev jhodgdev commented Apr 4, 2022

No description provided.

@jhodgdev jhodgdev added the enhancement New feature or request label Apr 4, 2022
@jhodgdev jhodgdev self-assigned this Apr 4, 2022
@jhodgdev jhodgdev mentioned this pull request Apr 4, 2022
Closed
@jhodgdev
Copy link
Contributor Author

jhodgdev commented Apr 5, 2022

Will add docstrings before submitting for review.

@jhodgdev jhodgdev marked this pull request as ready for review April 7, 2022 14:38
@jhodgdev
Copy link
Contributor Author

jhodgdev commented Apr 7, 2022

As I alluded to in the sprint, I am worried what I figured would be a 'quick thing useful for upstreaming' ran away from me a bit, so I don't know what in here is worth keeping but (I am sorry to say) there's a lot! Appreciate your review @delicious-lemon and/or @Geometer1729 .

@jhodgdev jhodgdev requested a review from AriFordsham April 7, 2022 14:40
Geometer1729
Geometer1729 suggested changes Apr 7, 2022
View reviewed changes
@jhodgdev jhodgdev mentioned this pull request Apr 25, 2022
Closed
@srid
Copy link
Contributor

srid commented Apr 26, 2022

@jhodgdev @delicious-lemon Any thoughts on making the bulk of Apropos.Gen.* in this PR as a library of its own, so it can be used in other projects, like Plutarch? Or do you envision these generators to be tightly coupled with apropos properties over time?

@jhodgdev
Copy link
Contributor Author

jhodgdev commented Apr 28, 2022

@srid I had always envisaged this work as only having utility for Apropos. You're more than welcome to use whatever you want from it though. What're your thoughts @delicious-lemon?

@jhodgdev jhodgdev requested a review from Geometer1729 April 28, 2022 14:08
@jhodgdev
Copy link
Contributor Author

jhodgdev commented May 3, 2022

So, I have been using this branch on Agora and am getting CekEvaluationErrors. Is that a problem stemming from the ScriptContexts I am using being non-sensical, or...? @delicious-lemon @Geometer1729

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@delicious-lemon delicious-lemon Awaiting requested review from delicious-lemon

@AriFordsham AriFordsham Awaiting requested review from AriFordsham

@Geometer1729 Geometer1729 Awaiting requested review from Geometer1729

1 more reviewer

@srid srid srid left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jhodgdev jhodgdev

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jhodgdev @srid @Geometer1729 @delicious-lemon @brainrake