Fix NFD_PickFolder() asserting in debug with non ASCII default path #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reproduce:
Call NFD_PickFolder() passing a non ASCII path for
defaultPath
on Windows with Visual Studio 2019, Win32 64 bits build.Description:
The sanity check in
CopyNFDCharToWChar()
assert (called bySetDefaultPath()
):This is caused by right shifting char which is negative, which is implementation defined behavior. I fixed this by casting to a unsigned value before shifting.
I was only able to test this in my own build env (VS 2019), so make sure to run it through your private build bots.