Add bandit to pre-commit

.pre-commit-config.yaml

@@ -16,3 +16,11 @@ repos:
             "-sn", # Don't display the score
             "--disable=fixme"
           ]
+  - repo: https://github.com/PyCQA/bandit
+    rev: 1.7.4
+    hooks:
+      - id: bandit
+        name: bandit
+        types: [python]
+        files: "^express/"
+        args: ["-f", "custom", "-q"]

express/gcp_storage.py

@@ -4,7 +4,6 @@
 import subprocess  # nosec
 import os
 import logging
-import tempfile
 from typing import List
 from urllib.parse import urlparse
 
@@ -103,23 +102,13 @@ def copy_files(source_files: List[str], destination: str):
              copy
             destination (str): the destination blob/folder to copy the files to
         """
+        with subprocess.Popen(  # nosec
+            ['gsutil', '-o', '"GSUtil:use_gcloud_storage=True"', '-q', '-m', 'cp', '-I',
+             destination], stdin=subprocess.PIPE
+        ) as gsutil_copy:
+            gsutil_copy.communicate(b"\n".join([f.encode() for f in source_files]))
 
-        # Write file paths to a text file before piping
-        with tempfile.TemporaryDirectory() as temp_folder:
-            upload_text_file = os.path.join(temp_folder, "files_to_upload.txt")
-            with open(upload_text_file, "w", encoding="utf-8") as out_file:
-                for file in source_files:
-                    out_file.write(file)
-                    out_file.write("\n")
-
-            # Write files to tmp director
-            with subprocess.Popen(["cat", upload_text_file], stdout=subprocess.PIPE) \
-                    as pipe_file_list:
-                subprocess.call(  # nosec
-                    ['gsutil', '-o', '"GSUtil:use_gcloud_storage=True"', '-q', '-m', 'cp', '-I',
-                     destination], stdin=pipe_file_list.stdout)
-
-            logger.info("A total of %s files were copied to %s", len(source_files), destination)
+        logger.info("A total of %s files were copied to %s", len(source_files), destination)
 
     def copy_file(self, source_file: str, destination: str) -> str:
         """

pyproject.toml

@@ -44,14 +44,10 @@ dataclasses-json = "^0.5.7"
 pandas = "^1.3.5"
 
 [tool.poetry.group.test.dependencies]
-bandit = { version = "^1.7.4", extras = ["toml"] }
 liccheck = "^0.7.3"
 pylint = "2.16.4"
 pre-commit = "^3.1.1"
 
-[tool.bandit]
-exclude_dirs = ["*/mlpipelines/components/sd_finetuning_component/src/train_text_to_image.py"]
-
 [build-system]
 requires = ["poetry-core>=1.2.0"]
 build-backend = "poetry.core.masonry.api"