Extend Ruff to tests and with extra rules #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbeSneyders
requested review from
GeorgesLorre,
PhilippeMoussalli and
NielsRogge
GeorgesLorre
approved these changes
May 8, 2023
RobbeSneyders
added a commit
that referenced
this pull request
May 8, 2023
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
This PR makes Ruff run on tests as well and adds extra rules: - More Pylint rules not yet covered by default checks - Isort for import order - Pydocstyle rules - I ignored quite a few rules here, which we might want to activate (D100 - D107), but we can do that in separate PRs as they require manual effort. I only had to fix one issue and add one local ignore. All other issues were auto-fixed, so these rules shouldn't lead to additional overhead.
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes Ruff run on tests as well and adds extra rules:
I only had to fix one issue and add one local ignore. All other issues were auto-fixed, so these rules shouldn't lead to additional overhead.