Align manifest and component spec schemas #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbeSneyders
requested review from
GeorgesLorre,
PhilippeMoussalli and
NielsRogge
NielsRogge
reviewed
Apr 25, 2023
| "required": [ | ||
| "name", | ||
| "description", | ||
| "image", |
There was a problem hiding this comment.
I was wondering whether the "image" is relevant for the Fondant spec, or whether this is only relevant for the Kubeflow spec. For the moment this field is not used
There was a problem hiding this comment.
It's necessary to build the kubeflow spec. I think it's logical that fondant components need to define the image they'll be executed with.
NielsRogge
approved these changes
Apr 25, 2023
PhilippeMoussalli
approved these changes
Apr 25, 2023
| } | ||
| "type": { | ||
| "type": "string", | ||
| "enum": [ |
There was a problem hiding this comment.
We have to remember to be able to pase those internally for the user since lists and dicts are often returned as json arrays.
There was a problem hiding this comment.
I'll create a ticket for it
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
This PR: - shares the `field` and `fields` definitions between the manifest and component spec - Moves object definitions into the `definitions` block for the component spec - Formats the schema files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
fieldandfieldsdefinitions between the manifest and component specdefinitionsblock for the component spec