-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align manifest and component spec schemas #39
Conversation
"required": [ | ||
"name", | ||
"description", | ||
"image", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering whether the "image" is relevant for the Fondant spec, or whether this is only relevant for the Kubeflow spec. For the moment this field is not used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's necessary to build the kubeflow spec. I think it's logical that fondant components need to define the image they'll be executed with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
} | ||
"type": { | ||
"type": "string", | ||
"enum": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to remember to be able to pase those internally for the user since lists and dicts are often returned as json arrays.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll create a ticket for it
This PR: - shares the `field` and `fields` definitions between the manifest and component spec - Moves object definitions into the `definitions` block for the component spec - Formats the schema files
This PR:
field
andfields
definitions between the manifest and component specdefinitions
block for the component spec