Extract kubeflow logic from ComponentSpec to KubeflowComponent #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbeSneyders
requested review from
GeorgesLorre,
PhilippeMoussalli and
NielsRogge
NielsRogge
reviewed
Apr 25, 2023
NielsRogge
reviewed
Apr 25, 2023
NielsRogge
reviewed
Apr 25, 2023
NielsRogge
reviewed
Apr 25, 2023
NielsRogge
reviewed
Apr 25, 2023
PhilippeMoussalli
approved these changes
Apr 25, 2023
| cls, fondant_component: FondantComponentSpec | ||
| ) -> "KubeflowComponentSpec": | ||
| """Create a Kubeflow component spec from a Fondant component spec.""" | ||
| specification = { |
There was a problem hiding this comment.
Nice :) more explicit than before
|
|
||
| return dumped_args | ||
|
|
||
| def to_file(self, path: t.Union[str, Path]) -> None: |
There was a problem hiding this comment.
I noticed that when compiling the kfp pipeline you can pass in directly a json string instead of the yaml file. So might be worth switching over to that approach. But this should be handled in separate PR related when automating the pipeline definition and compilation
There was a problem hiding this comment.
Ok, the json is available under _spec already, so should be easy to expose.
NielsRogge
approved these changes
Apr 25, 2023
RobbeSneyders
force-pushed
the
feature/component-spec
branch
from
9610aae
to
dff0568
Compare
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
This PR extracts all the kubeflow logic from the `ComponentSpec` to the `KubeflowComponent` so the `ComponentSpec` is a minimal representation of the fondant component specification. I also brought the classes a bit more in line with the `Manifest` class. This is preparation for the work to deduct the output manifest from the input manifest and component spec only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts all the kubeflow logic from the
ComponentSpecto theKubeflowComponentso theComponentSpecis a minimal representation of the fondant component specification. I also brought the classes a bit more in line with theManifestclass.This is preparation for the work to deduct the output manifest from the input manifest and component spec only.