Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dataset and Component Class #33
Add Dataset and Component Class #33
Changes from 26 commits
b5d1688
c67047b
3f258d5
a5f17bf
573fdda
a773496
d7de4ea
9e0b30a
325ead2
42613a3
5f4e103
8009d82
2ca256c
a151d96
cd474cc
4725981
63ac065
5f79090
cb0344b
1ce80bf
5720358
932e05e
c9f69b5
b185530
27ac896
d25ee12
3ac51b0
f654f35
2b922b8
4bb78d7
5675199
0951d5e
595a295
aecc259
b8d908c
45e4a17
7012700
43ec2b1
01b0f22
12ebf7e
7a6a108
8ecfb9f
bfb5e52
b4f8e92
f9c9679
b2aec33
ead2250
c20fa73
306f8f7
aafd9e3
9b3f339
6aa98ef
191310f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the CLIP model, which is https://huggingface.co/openai/clip-vit-large-patch14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we swtich over to using the t.Dict everywhere to be consistent. Also, if you're the
Dict
from thetyping
module, it's better to define the datatypes inside of it