Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pytest to Github actions #31

Merged
merged 6 commits into from
Apr 19, 2023
Merged

Add pytest to Github actions #31

merged 6 commits into from
Apr 19, 2023

Conversation

NielsRogge
Copy link
Contributor

This PR adds pytest to the Github actions, to make sure tests are run each time a PR is made.

@NielsRogge
Copy link
Contributor Author

NielsRogge commented Apr 14, 2023

@RobbeSneyders the test pipeline failed when not adding dataclasses_json:

ModuleNotFoundError: No module named 'dataclasses_json'

Even though there's a step before that installs all dependencies (which includes dataclasses_json). Are we sure that this step:

pip install poetry==1.4.0
poetry install

installs the dependencies of the package properly?

@RobbeSneyders
Copy link
Member

Since Poetry is not running in a virtual environment, it create and manages its own. This is cleaner for CI/CD, as Poetry's owns dependencies are not installed in the virtual environment. You can run a command in the virtual environment by running poetry run <command>.

See the docs for more info.

@NielsRogge
Copy link
Contributor Author

@RobbeSneyders thanks, have added back the "io" module to make all tests pass

@PhilippeMoussalli
Copy link
Contributor

PhilippeMoussalli commented Apr 19, 2023

@RobbeSneyders thanks, have added back the "io" module to make all tests pass

Can you remove io and test_io altogether, those functionalities are not used anymore

Copy link
Contributor

@PhilippeMoussalli PhilippeMoussalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. Just remove all the io stuff and it's ready to merge

@NielsRogge
Copy link
Contributor Author

@PhilippeMoussalli that means I can also remove the copy_folder and copy_file methods which rely on it?

@PhilippeMoussalli
Copy link
Contributor

@PhilippeMoussalli that means I can also remove the copy_folder and copy_file methods which rely on it?

yes they can be removed

@NielsRogge
Copy link
Contributor Author

I'll merge this and remove the io files in a separate PR, as they are still used in the soon-to-be-legacy storage helpers

@NielsRogge NielsRogge merged commit 06ea677 into main Apr 19, 2023
@RobbeSneyders RobbeSneyders deleted the add_pytest branch May 15, 2023 16:29
Hakimovich99 pushed a commit that referenced this pull request Oct 16, 2023
Add pytest to Github actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants