-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pytest to Github actions #31
Conversation
@RobbeSneyders the test pipeline failed when not adding dataclasses_json:
Even though there's a step before that installs all dependencies (which includes
installs the dependencies of the package properly? |
Since Poetry is not running in a virtual environment, it create and manages its own. This is cleaner for CI/CD, as Poetry's owns dependencies are not installed in the virtual environment. You can run a command in the virtual environment by running See the docs for more info. |
@RobbeSneyders thanks, have added back the "io" module to make all tests pass |
Can you remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this. Just remove all the io
stuff and it's ready to merge
@PhilippeMoussalli that means I can also remove the copy_folder and copy_file methods which rely on it? |
yes they can be removed |
I'll merge this and remove the io files in a separate PR, as they are still used in the soon-to-be-legacy storage helpers |
Add pytest to Github actions
This PR adds pytest to the Github actions, to make sure tests are run each time a PR is made.