Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alpha pipeline] Add segmentation component #149

Merged
merged 10 commits into from
May 22, 2023
Merged

Conversation

NielsRogge
Copy link
Contributor

This PR adds the final component of the ControlNet pipeline, namely the segmentation one.

@@ -0,0 +1,24 @@
export METADATA='{"run_id":"test_niels", "base_path":"/Users/nielsrogge/Documents/fondant_artifacts"}'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove this script when PR gets approved

Copy link
Contributor

@PhilippeMoussalli PhilippeMoussalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NielsRogge :) Seems like the development of the components is going fast now which is nice to see.

Left a few comments.

I feel like a lot of the dask inference stuff can be packaged into a common util at some point to make it easier to develop (not part of this PR). Wdyt?

Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NielsRogge!

Don't forget to remove the script.

@RobbeSneyders RobbeSneyders merged commit ef6fb10 into main May 22, 2023
@RobbeSneyders RobbeSneyders deleted the add_segmentation branch May 22, 2023 22:35
@RobbeSneyders RobbeSneyders linked an issue May 22, 2023 that may be closed by this pull request
Hakimovich99 pushed a commit that referenced this pull request Oct 16, 2023
This PR adds the final component of the ControlNet pipeline, namely the
segmentation one.

---------

Co-authored-by: Niels Rogge <nielsrogge@Nielss-MacBook-Pro.local>
Co-authored-by: Philippe Moussalli <philippe.moussalli95@gmail.com>
Co-authored-by: Robbe Sneyders <robbe.sneyders@ml6.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation component
3 participants