Skip to content

Commit

Permalink
Remove faker
Browse files Browse the repository at this point in the history
  • Loading branch information
mrchtr committed Mar 28, 2024
1 parent efae149 commit 135f951
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
2 changes: 0 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ google-cloud-aiplatform = { version = "1.34.0", optional = true}
sagemaker = {version = ">= 2.197.0", optional = true}
boto3 = {version = "1.28.64", optional = true}

Faker = ">= 24.4.0"

[tool.poetry.extras]
gpu = ["dask-cuda"]

Expand Down
6 changes: 3 additions & 3 deletions src/fondant/dataset/dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@
except ImportError:
from importlib_resources import files # type: ignore

import random

import pyarrow as pa
from faker import Faker

from fondant.component import BaseComponent
from fondant.core.component_spec import ComponentSpec, OperationSpec
Expand Down Expand Up @@ -535,8 +536,7 @@ def create(
An intermediate dataset.
"""
if dataset_name is None:
fake = Faker()
dataset_name = f"{fake.word()}-{fake.word()}"
dataset_name = f"dataset-{random.randint(1, 100)}" # nosec B311

operation = ComponentOp.from_ref(
ref,
Expand Down
3 changes: 2 additions & 1 deletion src/fondant/dataset/runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,8 @@ def check_docker_install():
.decode("utf-8")
)
docker_version = DockerRunner._versionify(res)

print("Docker version:")
print(docker_version)
if docker_version <= (20, 10, 0):
sys.exit(
"Docker version is not compatible. Please make sure "
Expand Down

0 comments on commit 135f951

Please sign in to comment.