-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix images in evaluation notebook #42
Conversation
Hi Hakim, these are the old images being added again, which don't reflect the true pipeline. Let's stick to the ones I added. Also really don't like the gif at the end. |
Oh alright alright
Ah okok, sorry I took them from Jan but didn't know there were other new images. But I actually don't see any image in the notebook from the main branch. Is it only me? |
They seem to be broken indeed, my bad. I posted the excalidraw with the latest images in chat. Can you update them? |
Sure! |
@@ -119,14 +111,14 @@ | |||
"outputs": [], | |||
"source": [ | |||
"!docker compose version\n", | |||
"!docker info >> /dev/null && echo \"Docker running\"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know why this was removed, but I don't think we need this output.
src/evaluation.ipynb
Outdated
"And of course feel free to give us a [**star** ⭐](https://github.com/ml6team/fondant) if you like what we are doing!\n", | ||
"\n", | ||
"<div align=\"center\">\n", | ||
"<img src=\"../art/feedback_is_important.webp\"/>\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would still remove this :)
a few changes brought by Jan to the notebooks.