Fix images in evaluation notebook #42
Conversation
Hakimovich99
changed the title
|
Hi Hakim, these are the old images being added again, which don't reflect the true pipeline. Let's stick to the ones I added. Also really don't like the gif at the end. |
Oh alright alright
Ah okok, sorry I took them from Jan but didn't know there were other new images. But I actually don't see any image in the notebook from the main branch. Is it only me? |
|
They seem to be broken indeed, my bad. I posted the excalidraw with the latest images in chat. Can you update them? |
Sure! |
| @@ -119,14 +111,14 @@ | |||
| "outputs": [], | |||
| "source": [ | |||
| "!docker compose version\n", | |||
| "!docker info >> /dev/null && echo \"Docker running\"" | |||
There was a problem hiding this comment.
Don't know why this was removed, but I don't think we need this output.
src/evaluation.ipynb
Outdated
| "And of course feel free to give us a [**star** ⭐](https://github.com/ml6team/fondant) if you like what we are doing!\n", | ||
| "\n", | ||
| "<div align=\"center\">\n", | ||
| "<img src=\"../art/feedback_is_important.webp\"/>\n", |
There was a problem hiding this comment.
Would still remove this :)
RobbeSneyders
changed the title
a few changes brought by Jan to the notebooks.