Skip to content

🧹 StyleTransfer getVariable method #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🧹 StyleTransfer getVariable method #1380

wants to merge 1 commit into from

Conversation

lindapaiste
Copy link
Contributor

This is a very minor code cleanup on the the StyleTransfer class.

  • Delete static method getVariableName(id)
  • Replace with instance method getVariable(id) which creates the variable name and returns the variable.
  • Rewrite all this.variables[StyleTransfer.getVariableName(id)] to this.getVariable(id)

@lindapaiste lindapaiste requested a review from joeyklee May 8, 2022 22:39
@lindapaiste lindapaiste mentioned this pull request Jun 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyklee joeyklee Awaiting requested review from joeyklee

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
style-transfer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lindapaiste