-
Notifications
You must be signed in to change notification settings - Fork 1
Extract metrics reloaded as a submodule #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Snyssfx is it ready to be reviewed and merged or you still need to commit some changes? |
|
@RamSaw oops, didn't see that there is travis CI, wait a few minutes, I will try to fix it |
310437a to
1992bb4
Compare
|
@RamSaw there it is. Change ssh to https url for submodule. |
|
As for commiting some changes, I added Readme.md to MetricsReloaded-gradle with instructions (for other projects) how to build submodule |
|
@Snyssfx strange behavior for me: I've cloned it, opened in IDEA and when I ran gradle task "assemble" it failed because gradle haven't found MetricsReloaded code (same behavior when I do it all from console without IDEA). When I run "buildDependents" it works fine and then all gradle targets (assemble, check etc.) work fine. But as I understood travis runs "./gradlew assemble" and it works fine for travis. But I can't understand why. Do you have any ideas? |
|
@RamSaw as I know, it's one of git submodules limitations. After clonning, you should execute in bash |
|
@RamSaw well, in this commit I have added |
No description provided.