Skip to content

Conversation

@RamSaw
Copy link
Contributor

@RamSaw RamSaw commented Nov 24, 2018

No description provided.

@RamSaw
Copy link
Contributor Author

RamSaw commented Nov 24, 2018

@Snyssfx is it ready to be reviewed and merged or you still need to commit some changes?
Seems like travis is unable to download MetricsReloaded.

@Snyssfx
Copy link
Contributor

Snyssfx commented Nov 24, 2018

@RamSaw oops, didn't see that there is travis CI, wait a few minutes, I will try to fix it

@Snyssfx Snyssfx force-pushed the extract-metrics-reloaded-as-a-submodule branch from 310437a to 1992bb4 Compare November 24, 2018 11:32
@Snyssfx
Copy link
Contributor

Snyssfx commented Nov 24, 2018

@RamSaw there it is. Change ssh to https url for submodule.

@Snyssfx
Copy link
Contributor

Snyssfx commented Nov 24, 2018

As for commiting some changes, I added Readme.md to MetricsReloaded-gradle with instructions (for other projects) how to build submodule

@RamSaw
Copy link
Contributor Author

RamSaw commented Nov 24, 2018

@Snyssfx strange behavior for me: I've cloned it, opened in IDEA and when I ran gradle task "assemble" it failed because gradle haven't found MetricsReloaded code (same behavior when I do it all from console without IDEA). When I run "buildDependents" it works fine and then all gradle targets (assemble, check etc.) work fine. But as I understood travis runs "./gradlew assemble" and it works fine for travis. But I can't understand why. Do you have any ideas?
Actually when I tried just to clone and just to run "./gradlew buildDependents" in console (without any use of IDEA) it failed because of unresolved references in MetricsReloaded (for example such error: "package org.jfree.chart.axis does not exist"). But if I run after that "assemble" it builds successfully. Seems strange to me.
Actually what gradle tasks do you execute to build the project successfully?
I think the best behavior will be the following: we just execute assemble and it builds successfully. Can we do so?

@Snyssfx
Copy link
Contributor

Snyssfx commented Nov 24, 2018

@RamSaw as I know, it's one of git submodules limitations. After clonning, you should execute in bash git submodule update --init --recursive.
If you check Travis logs, you will probably find this command after git clone ...

@Snyssfx
Copy link
Contributor

Snyssfx commented Nov 24, 2018

@RamSaw well, in this commit I have added submoduleUpdate gradle task, but my attempts to link it to building process was rather unsuccessful :(
You can launch it manually, however

@RamSaw RamSaw merged commit 287cee7 into master Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants