Repository navigation
Conversation
jrp2014
marked this pull request as ready for review
October 10, 2026 17:56
Contributor
Author
|
#4676 Has more on the failing tests. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 1-line fix for #4670, following the invitation in #4670 (comment).
The proposed cast in thus PR removes all 126 warnings; compilation and pre-commit checks pass.
The python suite ran 963 tests, with two test_qmm_splitk_precision failures (float16 and bfloat16):
I don't think that these are related to this fix, so I am ignoring them.
(For what it is worth, there seems to be a mismatch between the test’s assumptions and the kernel selected on this M5 Max:
So this looks like a test coverage/reference problem exposed by hardware-dependent dispatch, rather than split-K accumulation or the warning fix.)