Repository navigation
Refactor CPU Softmax dtype dispatch - #4127
Merged
Merged
Conversation
zcbenz
approved these changes
Aug 10, 2026
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace CPU
Softmax's explicit dtype switch withdispatch_all_types.The compile-time branches preserve the existing accumulator policy: float16
and bfloat16 use float accumulation in precise mode and their native types
otherwise, while float32 and float64 keep native accumulation. Other types
retain the existing unsupported-type error.
This removes eight net lines from one function.
Testing
float64, with precise mode both enabled and disabled (32 cases; transcripts
byte-identical)
only the adjacent include insertion to resolve; retaining both includes
produces identical source in either order, the combined Release library
builds, and the focused reduction/softmax suite passes
clang-formatandgit diff --check