Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use osx deployment target to pick Metal version #1595

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Use osx deployment target to pick Metal version #1595

merged 3 commits into from
Nov 19, 2024

Conversation

awni
Copy link
Member

@awni awni commented Nov 17, 2024 •
edited
Loading

Should close #1170. You can build with:

cmake .. -DCMAKE_OSX_DEPLOYMENT_TARGET=13.5

and it will use the correct version of Metal for that OS.

angeloskath
angeloskath approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@angeloskath angeloskath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@awni awni merged commit 9d7fa6b into main Nov 19, 2024
5 checks passed
@awni awni deleted the osx_deployment_target branch November 19, 2024 03:16
@awni awni mentioned this pull request Nov 19, 2024
Merged
@chimezie chimezie mentioned this pull request Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angeloskath angeloskath angeloskath approved these changes

@barronalex barronalex Awaiting requested review from barronalex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] be able to override MLX_METAL_VERSION when running cmake
2 participants
@awni @angeloskath