Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change initial memory limits and add memory size to device info #1064

Merged
merged 1 commit into from
May 3, 2024
Merged

Change initial memory limits and add memory size to device info #1064

merged 1 commit into from
May 3, 2024

Conversation

awni
Copy link
Member

@awni awni commented May 2, 2024 •
edited
Loading

  1. Add a memory_size field to the device_info dictionary
  2. Change the allocator memory limits to be more sensible. Previously on devices with large machines the memory limit is set to well over the total physical memory which is not a very sensible default.

LLM generation / transformer training timings did not change on M2 Ultra.

angeloskath
angeloskath approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@angeloskath angeloskath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@awni awni merged commit b00ac96 into main May 3, 2024
3 checks passed
@awni awni deleted the memory_limits branch May 3, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angeloskath angeloskath angeloskath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@awni @angeloskath