Repository navigation
package: exclude mlx/build cmake artifacts from Cmlx target - #402
Merged
davidkoski merged 1 commit intoSep 28, 2026
Merged
Conversation
davidkoski
force-pushed
the
fix/exclude-cmake-build-artifacts
branch
from
August 17, 2026 21:44
7851eb3 to
d7b087c
Compare
davidkoski
approved these changes
Aug 17, 2026
davidkoski
left a comment
davidkoski
left a comment
Member
There was a problem hiding this comment.
Change looks good, just waiting on CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running
cmake -B build(standard cmake workflow) createsmlx/build/_deps/doctest-src/scripts/hello_world.cpp, which containsmain(). SwiftPM scans the full Cmlx source tree and finds this file,classifying the target as an executable instead of a library:
Fix
Add
"mlx/build"to theexcludedSourceslist of the Cmlx target.Impact
One line added to Package.swift. No API change, no behaviour change.
Lets contributors build mlx with
cmake -B buildalongside a Swiftconsumer of the package without errors.