This repository was archived by the owner on Jul 30, 2019. It is now read-only.
Redone the way we match for correct language #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t translation language
dominik-hadl
suggested changes
Apr 12, 2017
|
|
||
| /// In memory cache of the last language object. | ||
| public fileprivate(set) var currentLanguage: Language? | ||
| public var currentLanguage: Language? |
There was a problem hiding this comment.
Should this be changeable outside the framework? I think this property should stay public read-only with internal setter. For the language overriding feature users can use the languageOverride property.
| return languageDictionary | ||
| } | ||
| } | ||
| // Take preferred language form backend |
dominik-hadl
approved these changes
Apr 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to not take into account what the backend told was the best fit language.
This update will use this before trying to match the list of NStack provided languages with the preferred locale.
Please give it a rough review as im not 100% into all the NStack translations use cases.