Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make new arch work on iOS #133

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix: make new arch work on iOS #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions example/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1145,7 +1145,7 @@ PODS:
- React-Core
- React-jsi
- ReactTestApp-Resources (1.0.0-dev)
- RNReactNativeHapticFeedback (2.3.0):
- RNReactNativeHapticFeedback (2.3.1):
- DoubleConversion
- glog
- RCT-Folly (= 2024.01.01.00)
Expand Down Expand Up @@ -1402,10 +1402,10 @@ SPEC CHECKSUMS:
ReactNativeHost: 4983b4bfdef9f1a67f523b633909df57a9c1dae9
ReactTestApp-DevSupport: f781365c3ae6377dcfa2affe319ae66e0fb20777
ReactTestApp-Resources: 857244f3a23f2b3157b364fa06cf3e8866deff9c
RNReactNativeHapticFeedback: 1c82b2b3d51105a01ed0d4b1d696319479e2c777
RNReactNativeHapticFeedback: 5945b9c7a2e9db8df62e1d94063d8a135c187f32
SocketRocket: abac6f5de4d4d62d24e11868d7a2f427e0ef940d
Yoga: 0efb3e1bd40ba59b009f01badea863281101de78

PODFILE CHECKSUM: 58b1b5d965384968b1dd12f033ef182aec4c1b6b

COCOAPODS: 1.14.3
COCOAPODS: 1.15.2
2 changes: 0 additions & 2 deletions ios/RNHapticFeedback.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@

/* Begin PBXFileReference section */
134814201AA4EA6300B7C361 /* libRNHapticFeedback.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; includeInIndex = 0; path = libRNHapticFeedback.a; sourceTree = BUILT_PRODUCTS_DIR; };
3FAF13E52C6144D7002E28B1 /* RNHapticFeedbackSpec.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = RNHapticFeedbackSpec.h; path = RNHapticFeedback/RNHapticFeedbackSpec.h; sourceTree = "<group>"; };
558CBA9028EF1100007CF242 /* RNHapticFeedback.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = RNHapticFeedback.h; path = RNHapticFeedback/RNHapticFeedback.h; sourceTree = "<group>"; };
558CBA9128EF1100007CF242 /* DeviceUtils.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = DeviceUtils.h; path = RNHapticFeedback/DeviceUtils.h; sourceTree = "<group>"; };
558CBA9228EF1100007CF242 /* DeviceUtils.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = DeviceUtils.mm; path = RNHapticFeedback/DeviceUtils.mm; sourceTree = "<group>"; };
Expand Down Expand Up @@ -54,7 +53,6 @@
58B511D21A9E6C8500147676 = {
isa = PBXGroup;
children = (
3FAF13E52C6144D7002E28B1 /* RNHapticFeedbackSpec.h */,
558CBA9128EF1100007CF242 /* DeviceUtils.h */,
558CBA9228EF1100007CF242 /* DeviceUtils.mm */,
558CBA9028EF1100007CF242 /* RNHapticFeedback.h */,
Expand Down
4 changes: 2 additions & 2 deletions ios/RNHapticFeedback/RNHapticFeedback.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#ifdef RCT_NEW_ARCH_ENABLED
#import "RNHapticFeedbackSpec.h"
#import <RNHapticFeedbackSpec/RNHapticFeedbackSpec.h>

@interface RNHapticFeedback : NSObject <NativeHapticFeedbackSpec>
#else
Expand All @@ -25,4 +25,4 @@ typedef NS_ENUM(NSInteger, FeedbackType) {

- (Boolean)supportsHaptic;

@end
@end
15 changes: 0 additions & 15 deletions ios/RNHapticFeedback/RNHapticFeedbackSpec.h
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,6 @@
"source": "src/index.ts",
"main": "./lib/commonjs/index.js",
"module": "./lib/module/index.js",
"exports": {
".": {
"import": {
"types": "./lib/typescript/module/src/index.d.ts",
"default": "./lib/module/index.js"
},
"require": {
"types": "./lib/typescript/commonjs/src/index.d.ts",
"default": "./lib/commonjs/index.js"
}
}
},
"scripts": {
"typecheck": "tsc --noEmit --project tsconfig.test.json",
"test": "jest",
Expand Down