Skip to content

Update route-loader to use Webpack 4 dynamic import() Promise with named chunks #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update route-loader to use Webpack 4 dynamic import() Promise with named chunks #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions src/route-loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,13 @@ const loaderUtils = require('loader-utils');
function asyncRequire(page, chunk, shouldChunk) {
// load in main chunk if explicitly specified, or if chunks option was set to false
if ((chunk && chunk === 'main') || (!chunk && shouldChunk === false)) {
return `Promise.resolve(require('${page}').default)`;
return `import('${page}').then(m => m.default)`;
}
// load in separate chunk if chunk name was not specified, or if is not named "main"
return `new Promise(function (resolve, reject) {
try {
require.ensure(['${page}'], function (require) {
resolve(require('${page}').default);
}${typeof chunk === 'string' ? `, '${chunk}'` : ''});
} catch (err) {
reject(err);
}
})`;
return `import(${typeof chunk === 'string' ? `
/* webpackChunkName: "${chunk}" */` : ''}
'${page}'
).then(m => m.default)`;
}

/**
Expand Down