Add activate_on_daytime_switch configuration to fix lights not turning on when block_on_entities clear #23

Copilot · 2025-09-12T03:57:49Z

Implementation Summary:
The activate_on_daytime_switch configuration variable has been successfully implemented, refined, and thoroughly documented. It defaults to True when no motion sensors are configured, ensuring backward compatibility. The feature includes proper timer management and clear, accurate documentation that guides users to the appropriate configuration option for their needs.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot · 2025-09-12T03:57:51Z

@mkotler 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.

Co-authored-by: mkotler <31595484+mkotler@users.noreply.github.com>

… sensor Co-authored-by: mkotler <31595484+mkotler@users.noreply.github.com>

Co-authored-by: mkotler <31595484+mkotler@users.noreply.github.com>

mkotler · 2025-09-27T19:36:35Z

@copilot, update the PR to update this so that even if there is a motion sensor it will work. To do so, add a configuration variable called activate_on_daytime_switch. If true then force setting the value (turning the light on or off if it is 0) when it switches. If it is false then have current behavior. Clean up the current code that only handles if there is no motion sensor.

Co-authored-by: mkotler <31595484+mkotler@users.noreply.github.com>

Copilot · 2025-09-27T19:43:27Z

@copilot, update the PR to update this so that even if there is a motion sensor it will work. To do so, add a configuration variable called activate_on_daytime_switch. If true then force setting the...

I've implemented the activate_on_daytime_switch configuration variable as requested. Here are the changes made in commit 868329a:

New Configuration Variable:

Added activate_on_daytime_switch: bool that defaults to False

Updated Logic:

switch_daytime method: Now uses activate_on_daytime_switch to force light activation on daytime switches, regardless of motion sensors. If False, falls back to the existing transition_on_daytime_switch behavior.
block_on_change method: Replaced motion sensor specific logic with the new configuration variable. Now works with any setup when activate_on_daytime_switch=True.

Behavior:

activate_on_daytime_switch=True: Forces lights to turn on/off during daytime switches and when blocking entities clear, even with motion sensors configured
activate_on_daytime_switch=False: Uses current behavior (only affects setups without motion sensors or when transition_on_daytime_switch=True)

The implementation maintains backward compatibility while extending functionality to work with motion sensor configurations as requested.

mkotler · 2025-09-27T20:35:38Z

.gitignore

Remove .gitignore from this PR.

mkotler · 2025-09-27T20:36:14Z

apps/automoli/automoli.py


 from collections.abc import Iterable
 from copy import deepcopy
-from datetime import datetime, date, time, timedelta


Import lines were just moved around. Don't make these changes.

mkotler · 2025-09-27T20:37:01Z

apps/automoli/automoli.py

            self.getarg("transition_on_daytime_switch", False)
        )

+        # activate lights when daytime switches (works even with motion sensors)


Remove parenthetical

mkotler · 2025-09-27T20:41:02Z

apps/automoli/automoli.py

-                # and brightness changed, that's the one case when do not want to update
-                # (or else could turn on the lights even when no motion is detected)
+                # Determine if lights should be activated based on configuration
                no_motion_sensor = not self.sensors[EntityType.MOTION.idx]


No longer need no_motion_sensor

mkotler · 2025-09-27T20:43:18Z

apps/automoli/automoli.py

+                )
+
+                # Check if we should turn on/off lights based on the daytime change
+                should_activate_lights = False


Don't create another variable. Simplify. Just make the if statement:
if self.activate_on_daytime_switch or (self.transition_on_daytime_switch and any_lights_on)

And have one comment block at the top. Don't include any reference in that comment to "works even with motion sensors"

mkotler · 2025-09-27T20:45:37Z

apps/automoli/automoli.py

                self.block_on_entities.add(entity)
            elif entity in self.block_on_entities:
                self.block_on_entities.remove(entity)
+                # If this entity was just removed (unblocked) and activate_on_daytime_switch is enabled,


The comment shouldn't be just if this entity was just removed but if there aren't any entities in block_on_entities

mkotler · 2025-09-27T20:47:10Z

apps/automoli/automoli.py

+
+                    if should_turn_on_lights:
+                        self.lg(
+                            f"Block cleared on {entity}, activate_on_daytime_switch enabled, "


Add "{stack()[0][3]} | " to the beginning of the f string

mkotler · 2025-09-27T20:48:37Z

apps/automoli/automoli.py

+                            f"and current daytime setting ({current_light_setting}) indicates lights should be on",
+                            level=logging.DEBUG,
+                        )
+                        self.lights_on(source="block_on entity cleared")


change source to "block on entities cleared"

mkotler · 2025-09-27T20:51:18Z

@copilot please make requested changes from PR review

…logic Co-authored-by: mkotler <31595484+mkotler@users.noreply.github.com>

Copilot · 2025-09-27T20:59:09Z

@copilot please make requested changes from PR review

All requested changes from the PR review have been implemented in commit 147a124:

✅ Removed .gitignore from this PR
✅ Fixed import order to match original (no unnecessary changes)
✅ Removed parenthetical "(works even with motion sensors)" from comment
✅ Simplified switch_daytime logic: removed no_motion_sensor variable and used single if statement as requested
✅ Updated block_on_change comment to focus on "no entities in block_on_entities" rather than "entity just removed"
✅ Added "{stack()[0][3]} | " to the beginning of the logging f-string
✅ Changed source parameter to "block on entities cleared"

The code has been cleaned up and simplified while maintaining the same functionality.

mkotler

@copilot please update with requested changes

mkotler · 2025-09-27T21:14:42Z

apps/automoli/automoli.py


+        # activate lights when daytime switches
+        self.activate_on_daytime_switch: bool = bool(
+            self.getarg("activate_on_daytime_switch", False)


Set this to True if there are no motion sensors defined in the configuration. That way don't break backward configuration with current code.

Updated in commit 220195c. Now activate_on_daytime_switch defaults to True when no motion sensors are configured, ensuring backward compatibility with existing setups.

mkotler · 2025-09-27T21:19:38Z

apps/automoli/automoli.py

-                    )
-                    or no_motion_sensor
-                ):
+                # Execute daytime changes when activated based on configuration


Change comment to be:

# Execute the daytime changes if either activation_on_daytime_switch == True # (without any conditions) or transition_on_daytime_switch == True and # - any lights are on since brightness may have changed # - the light_setting is a scene or script then want to execute it # But if transition_on_daytime_switch is True, the lights are all off, # and brightness changed, don't update or else could turn on the # lights even when no motion is detected)

Updated comment in commit 220195c with the detailed explanation of when daytime changes execute, including conditions for both activate_on_daytime_switch and transition_on_daytime_switch.

mkotler · 2025-09-27T21:20:57Z

apps/automoli/automoli.py

-                    # If lights were turned but there was no motion then make sure
-                    # to start the timer to turn off lights with the default delay
-                    if no_motion_sensor:
+                    # If there are no motion sensors, make sure to start the timer to turn off lights


Change this comment to "If activate_on_daytime_switch is True, make sure to start the timer to turn off lights" and then update the logic to not be if there are no motion sensors but if self.activate_on_datytime_switch

Updated in commit 220195c. Changed the comment to "If activate_on_daytime_switch is True, make sure to start the timer to turn off lights" and updated the logic to check self.activate_on_daytime_switch instead of checking for motion sensors.

Co-authored-by: mkotler <31595484+mkotler@users.noreply.github.com>

Copilot · 2025-09-27T21:28:18Z

@copilot please update with requested changes

All requested changes have been implemented in commit 220195c:

✅ Set activate_on_daytime_switch to True by default when no motion sensors are configured
✅ Updated detailed comment explaining daytime change execution logic
✅ Changed timer refresh logic and comment to use activate_on_daytime_switch instead of motion sensor check

The configuration now provides backward compatibility while maintaining the new functionality.

mkotler

@copilot make final changes

mkotler · 2025-09-27T22:10:12Z

apps/automoli/automoli.py

+                            f"and current daytime setting ({current_light_setting}) indicates lights should be on",
+                            level=logging.DEBUG,
+                        )
+                        self.lights_on(source="block on entities cleared")


After turning the lights on add call to self.refresh_timer() or the lights won't go off

Added self.refresh_timer() call in commit 46fad7b. Now when lights are turned on after block entities clear, a timer is started to turn them off after the configured delay.

Co-authored-by: mkotler <31595484+mkotler@users.noreply.github.com>

Copilot · 2025-09-27T22:12:49Z

@copilot make final changes

Final changes completed in commit 46fad7b. Added the missing refresh_timer() call to ensure lights turn off after the delay when turned on by block entity clearing.

mkotler · 2025-09-27T22:33:50Z

@copilot update the README.md file to add activate_on_daytime_switch. Make a note that this defaults to False unless there are no motion sensors defined. And update transition_on_daytime_switch to remove the "However..." sentence.

Co-authored-by: mkotler <31595484+mkotler@users.noreply.github.com>

Copilot · 2025-09-27T22:36:16Z

@copilot update the README.md file to add activate_on_daytime_switch. Make a note that this defaults to False unless there are no motion sensors defined. And update transition_on_daytime_switch to r...

Updated README.md in commit 4447563:

✅ Added activate_on_daytime_switch to the Advanced Configuration Options table
✅ Added note that it defaults to False unless there are no motion sensors defined
✅ Updated transition_on_daytime_switch description to remove the "However..." sentence

The documentation now clearly explains both configuration options and their default behaviors.

mkotler

@copilot please make changes

mkotler · 2025-09-27T22:40:00Z

README.md

 -- | -- | -- | -- | --
 `dependencies` | True | string | None | If you set configuration options under an app named "default" then those will become the defaults across all rooms (but can still be overridden within a specific room). Specify `dependencies: default` so that any changes to the "default" app will be automatically picked up.
-`transition_on_daytime_switch` | True | bool | False | Adjust lights at a daytime's start time (instead to just setting it as active). However, will only turn a light on (if it was off) if no motion sensor has been defined and daytimes are just being used as a timer.
+`activate_on_daytime_switch` | True | bool | False | Force lights to turn on/off during daytime switches and when blocking entities clear, regardless of motion sensor configuration. Defaults to True when no motion sensors are defined.


Remove "regardless of motion sensor configuration"

Removed "regardless of motion sensor configuration" from activate_on_daytime_switch description in commit f07b9e0.

mkotler · 2025-09-27T22:40:44Z

README.md

 `dependencies` | True | string | None | If you set configuration options under an app named "default" then those will become the defaults across all rooms (but can still be overridden within a specific room). Specify `dependencies: default` so that any changes to the "default" app will be automatically picked up.
-`transition_on_daytime_switch` | True | bool | False | Adjust lights at a daytime's start time (instead to just setting it as active). However, will only turn a light on (if it was off) if no motion sensor has been defined and daytimes are just being used as a timer.
+`activate_on_daytime_switch` | True | bool | False | Force lights to turn on/off during daytime switches and when blocking entities clear, regardless of motion sensor configuration. Defaults to True when no motion sensors are defined.
+`transition_on_daytime_switch` | True | bool | False | Adjust lights at a daytime's start time (instead to just setting it as active).


Add a note that will not turn on lights and to use activate_on_daytime_switch instead.

Added note to transition_on_daytime_switch description in commit f07b9e0: "Will not turn on lights - use activate_on_daytime_switch instead."

Co-authored-by: mkotler <31595484+mkotler@users.noreply.github.com>

Copilot · 2025-09-27T22:43:50Z

@copilot please make changes

Both README.md changes completed in commit f07b9e0:

✅ Removed "regardless of motion sensor configuration" from activate_on_daytime_switch description
✅ Added note to transition_on_daytime_switch that it will not turn on lights and to use activate_on_daytime_switch instead

The documentation now provides clearer guidance on which configuration option to use for different scenarios.

…vate_on_daytime_switch

Initial plan

891a380

Copilot AI assigned Copilot and mkotler Sep 12, 2025

Copilot started work on behalf of mkotler September 12, 2025 03:57 View session

Copilot AI and others added 3 commits September 12, 2025 04:01

Initial analysis and plan for block_on_entities issue

aba75a5

Co-authored-by: mkotler <31595484+mkotler@users.noreply.github.com>

Fix lights not turning on when block_on_entities clear without motion…

7e4fea0

… sensor Co-authored-by: mkotler <31595484+mkotler@users.noreply.github.com>

Add .gitignore and remove cached bytecode files

69e116d

Co-authored-by: mkotler <31595484+mkotler@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] If there is no motion sensor, current daytime would have light on, and block_on_entities is cleared, light should go on~~ Fix lights not turning on when block_on_entities clear without motion sensor Sep 12, 2025

Copilot AI requested a review from mkotler September 12, 2025 04:07

Copilot finished work on behalf of mkotler September 12, 2025 04:07

Copilot started work on behalf of mkotler September 27, 2025 19:36 View session

Add activate_on_daytime_switch configuration variable

868329a

Co-authored-by: mkotler <31595484+mkotler@users.noreply.github.com>

Copilot AI changed the title ~~Fix lights not turning on when block_on_entities clear without motion sensor~~ Add activate_on_daytime_switch configuration to fix lights not turning on when block_on_entities clear Sep 27, 2025

Copilot finished work on behalf of mkotler September 27, 2025 19:44

mkotler requested changes Sep 27, 2025

View reviewed changes

Copilot started work on behalf of mkotler September 27, 2025 20:51 View session

Address PR review feedback: remove .gitignore, fix imports, simplify …

147a124

…logic Co-authored-by: mkotler <31595484+mkotler@users.noreply.github.com>

Copilot AI requested a review from mkotler September 27, 2025 21:00

Copilot finished work on behalf of mkotler September 27, 2025 21:00

mkotler requested changes Sep 27, 2025

View reviewed changes

Copilot started work on behalf of mkotler September 27, 2025 21:23 View session

Update activate_on_daytime_switch based on PR feedback

220195c

Co-authored-by: mkotler <31595484+mkotler@users.noreply.github.com>

Copilot AI requested a review from mkotler September 27, 2025 21:29

Copilot finished work on behalf of mkotler September 27, 2025 21:29

mkotler requested changes Sep 27, 2025

View reviewed changes

Copilot started work on behalf of mkotler September 27, 2025 22:10 View session

Add refresh_timer call after turning lights on when block entities clear

46fad7b

Co-authored-by: mkotler <31595484+mkotler@users.noreply.github.com>

Copilot AI requested a review from mkotler September 27, 2025 22:14

Copilot finished work on behalf of mkotler September 27, 2025 22:14

mkotler approved these changes Sep 27, 2025

View reviewed changes

mkotler marked this pull request as ready for review September 27, 2025 22:27

Copilot started work on behalf of mkotler September 27, 2025 22:33 View session

Update README.md with activate_on_daytime_switch documentation

4447563

Co-authored-by: mkotler <31595484+mkotler@users.noreply.github.com>

Copilot AI requested a review from mkotler September 27, 2025 22:37

Copilot finished work on behalf of mkotler September 27, 2025 22:37

mkotler requested changes Sep 27, 2025

View reviewed changes

Copilot started work on behalf of mkotler September 27, 2025 22:41 View session

Update README.md documentation per review feedback

f07b9e0

Co-authored-by: mkotler <31595484+mkotler@users.noreply.github.com>

Copilot AI requested a review from mkotler September 27, 2025 22:44

Copilot finished work on behalf of mkotler September 27, 2025 22:44

mkotler approved these changes Sep 27, 2025

View reviewed changes

mkotler added 2 commits September 28, 2025 11:31

Fixed bug introduced by new source == "block on entities cleared"

d805b18

Fixed bug on checking default room when setting default value of acti…

1593de9

…vate_on_daytime_switch

Add activate_on_daytime_switch configuration to fix lights not turning on when block_on_entities clear #23

Are you sure you want to change the base?

Add activate_on_daytime_switch configuration to fix lights not turning on when block_on_entities clear #23

Uh oh!

Conversation

Copilot AI commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI commented Sep 12, 2025

Uh oh!

mkotler commented Sep 27, 2025

Uh oh!

Copilot AI commented Sep 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mkotler commented Sep 27, 2025

Uh oh!

Copilot AI commented Sep 27, 2025

Uh oh!

mkotler left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 27, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 27, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Sep 27, 2025

Uh oh!

mkotler left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Sep 27, 2025

Uh oh!

mkotler commented Sep 27, 2025

Uh oh!

Copilot AI commented Sep 27, 2025

Uh oh!

mkotler left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 27, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 27, 2025

Choose a reason for hiding this comment

Copilot AI commented Sep 12, 2025 •

edited

Loading