Skip to content

Include port in X-Forwarded-Host header if not default #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jwgmeligmeyling
Copy link

@jwgmeligmeyling jwgmeligmeyling commented May 28, 2021

Fixes #122.

After looking into it a bit better the resources are quite contradicting each other on whether the port should be in the header or not.

Perhaps we could at least make the behaviour configurable to support both flavors?

@codecov-commenter
Copy link

Codecov Report

Merging #124 (fae1a4b) into master (f6311c9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #124   +/-   ##
=========================================
  Coverage     90.80%   90.81%           
  Complexity      542      542           
=========================================
  Files           167      167           
  Lines          1849     1851    +2     
  Branches         54       55    +1     
=========================================
+ Hits           1679     1681    +2     
  Misses          148      148           
  Partials         22       22           
Impacted Files Coverage Δ
...ors/rewrite/CommonRequestProxyHeadersRewriter.java 95.83% <100.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6311c9...fae1a4b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include port in X-Forwarded-Host header if its not the standard port for the scheme
3 participants