Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 617 #623

Merged
merged 25 commits into from
Oct 10, 2019
Merged

Conversation

v-makouz
Copy link
Contributor

Fixing the insertion of high unicode characters, bug caused by SQLPutData being given the number of characters, rather then code points, which causes problems for characters are more code points then usual

@mkleehammer
Copy link
Owner

Looks good. Small change request - could you change the table to "t1". Tests use t0-t2 which are automatically dropped before each test. (Also, I'm not sure why it is using executemany instead of execute. Is that on purpose?)

@v-makouz
Copy link
Contributor Author

v-makouz commented Oct 10, 2019

@mkleehammer I renamed the table, as for why it's executemany I simply based the test on the OP's repro script, I wanted to keep it as close as possible, since that's what originally indicated the problem

@mkleehammer mkleehammer merged commit 969ea2c into mkleehammer:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants