Add error subclass mappings for more SQLSTATEs #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect more operational error codes so we can raise more specific error classes for these known cases (seen coming from MSSQL — I can't vouch that these offer any improvement for other DBMSs).
mkleehammer
requested changes
Sep 20, 2017
| @@ -19,15 +19,27 @@ struct SqlStateMapping | |||
|
|
|||
| static const struct SqlStateMapping sql_state_mapping[] = | |||
| { | |||
| { "01002", 5, &OperationalError }, | |||
| { "08001", 5, &OperationalError }, | |||
| { "08003", 5, &OperationalError }, | |||
There was a problem hiding this comment.
08003 is "Connection not open". Wouldn't that be ProgrammingError?
There was a problem hiding this comment.
When we've had it, it has been the result of executing a query on a connection that has unexpectedly closed at the server end (eg due to a timeout), which feels more like an operational problem.
(Although, it's unclear whether this is what the sqlstate is supposed to represent, as the definitions are pretty fuzzy and don't necessarily match reality...)
There was a problem hiding this comment.
Well then, let's leave them as-is. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect more operational error codes so we can raise more specific error classes for these known cases (seen coming from MSSQL — I can't vouch that these offer any improvement for other DBMSs).