Homework #1
Homework #1
Conversation
| * @param {int} limit | ||
| */ | ||
| async function getContributors(organization, limit = 3) { | ||
| async function getContributorsOfReposByOwner(owner, repo) { |
| * @param {int} limit | ||
| */ | ||
| async function getContributors(organization, limit = 3) { | ||
| async function getContributorsOfReposByOwner(owner, repo) { |
There was a problem hiding this comment.
async function everytime returns promise. Here await unpacks promise, but async packs value in promise.
More efficient return request
| })).slice(0, limit); | ||
|
|
||
| for(i in repos) { | ||
| contributors[repos[i].name] = (await getContributorsOfReposByOwner( |
There was a problem hiding this comment.
With await, we will wait when is finished a previous request to start next request.
You need to use Promise.all to make them parallelly.
const contributors = await Promis.all(repos.map(repo => ..))
| allresult.map(([repo, contributorsOfReposByOwner]) => { | ||
| contributors[repo] = contributorsOfReposByOwner.map((data) => data.login); | ||
| }); | ||
| resolve(contributors); |
There was a problem hiding this comment.
resolve we can use when we work with the callbacks.
Here Promise chain and Promise.all is enough.
| */ | ||
| function getContributors(organization, limit = 3) { | ||
| return new Promise(function(resolve) { | ||
| function getContributorsOfReposByOwner(owner, repo) { |
| "User-Agent": "request-promise" | ||
| } | ||
| }).then((repos) => { | ||
| Promise.all(repos.slice(0, limit).map((repo) => { |
There was a problem hiding this comment.
You need to return Promise.all and then you can use .then((allresult) on the same level as .then((repos)
webwin0
left a comment
webwin0
left a comment
There was a problem hiding this comment.
Move getContributorsOfReposByOwner outside and refactor promise getContributors in 02_promise.js
You don't need new Promise there.
No description provided.