Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the build instructions to handle updated dependency versions #227

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

skypanther
Copy link

@skypanther skypanther commented Oct 2, 2020

I had troubles building and discovered it was mostly a difference between dependency versions (Python version, Qt version). This PR updates the build instructions with details on what you need to tweak in order to get the app built.

Closes #225

@mkeeter
Copy link
Owner

mkeeter commented Oct 2, 2020

Thanks for the PR! I'm confused as to whether editing CMakeLists.txt is actually necessary: when I build on my Mac, I see

-- Found Python: /usr/local/Frameworks/Python.framework/Versions/3.8/bin/python3.8 (found suitable version "3.8.5", minimum required is "3.3") found components: Interpreter Development Development.Module Development.Embed

implying that it's happy to select later Python versions if they exist.

What error messages were you seeing that led you to this solution?

@skypanther
Copy link
Author

skypanther commented Oct 3, 2020

I get this:

(I have Qt 5.15.5 5.15.1, hence the updated cmake command below)

Console output removed because it works when you use the right version number. 🤦 I'll update the PR to remove instructions about editing the CMakeLists.txt file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to build on Mac Catalina (10.15.6)
2 participants