Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow resolving alias to any external module #61

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

gilfree
Copy link
Contributor

@gilfree gilfree commented Feb 15, 2023

This PR extends #60 to allow loading any external module

Copy link
Member

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a suggestion for the docs.Feel free to rephrase it again, I'm not the best technical writer.

docs/usage.md Outdated Show resolved Hide resolved
src/mkdocstrings_handlers/python/handler.py Outdated Show resolved Hide resolved
@gilfree gilfree force-pushed the load_external_modules2 branch from 6574ace to 3082735 Compare March 6, 2023 09:57
@gilfree
Copy link
Contributor Author

gilfree commented Mar 6, 2023

Hi @pawamoy, I have rebased and update according to the changes you requested

Copy link
Member

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pawamoy pawamoy merged commit 02052e2 into mkdocstrings:master Mar 7, 2023
@gilfree gilfree deleted the load_external_modules2 branch March 7, 2023 19:28
@gilfree
Copy link
Contributor Author

gilfree commented Mar 20, 2023

Hi @pawamoy.

Do you plan a release with these fixes in the near time?
Are you waiting to more features/fixes to accumulate or have some future release date in mind?

@pawamoy
Copy link
Member

pawamoy commented Mar 21, 2023

I'll try to release a new version tomorrow 🙂 Thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants