fix: skip Docker bridge interface when selecting default address#177
Open
vilchanskyio-work wants to merge 1 commit intomkckr0:mainfrom
Open
fix: skip Docker bridge interface when selecting default address#177vilchanskyio-work wants to merge 1 commit intomkckr0:mainfrom
vilchanskyio-work wants to merge 1 commit intomkckr0:mainfrom
Conversation
When Docker is running, its default bridge (172.17.0.0/16) was picked as the server's default address instead of the real LAN interface, because 172.17/16 falls inside RFC 1918 172.16/12, the old single-pass scan couldn't distinguish them. A virtual-interface denylist (initially containing 172.17.0.0/16) is now checked before the private-address scan, skipping known container bridges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Docker is running, its default bridge (172.17.0.0/16) was picked as the server's default address instead of the real LAN interface, because 172.17/16 falls inside RFC 1918 172.16/12, the old single-pass scan couldn't distinguish them. A virtual-interface denylist (initially containing 172.17.0.0/16) is now checked before the private-address scan, skipping known container bridges.